futures-lite icon indicating copy to clipboard operation
futures-lite copied to clipboard

Published 20 hours ago • verified publisher icon smol-rs

Re-export `pending` from `std` rather than redefining it

Open joshtriplett opened this issue 2 years ago • 1 comments

This avoids having two versions of pending in programs that use both futures_lite and the version from std.

joshtriplett avatar Jun 20 '22 08:06 joshtriplett

Thanks for the PR. Unfortunately, if the user implements the same trait on both types, this is a breaking change.

(https://github.com/smol-rs/futures-lite/issues/35 is an issue to track this change.)

taiki-e avatar Jun 20 '22 11:06 taiki-e

Given that this is a breaking change anyways, it doesn't really make sense to merge this because the user would need to manually fix their code anyways (given a corresponding bump of the crate version). So I'd reject this PR.

fogti avatar Nov 06 '22 18:11 fogti

Given that this is a breaking change anyways, it doesn't really make sense to merge this because the user would need to manually fix their code anyways (given a corresponding bump of the crate version). So I'd reject this PR.

I'd agree with rejection.

notgull avatar Nov 06 '22 18:11 notgull