Taiki Endo

Results 934 comments of Taiki Endo

Documented in https://github.com/tokio-rs/loom/pull/253, but is not in the readme or crate-level docs.

This seems due to that visit_token_stream_impl only visits `yield` but not `?`. https://github.com/tokio-rs/async-stream/blob/8bf33a6d2cf00257a9235a14ae264aa5c74380ba/async-stream-impl/src/lib.rs#L45-L94

> Disadvatanges of using the new API: I think the lack of the `for await` syntax would also be included in this list.

cc @carllerche @Darksonn @Kestrer: any thoughts on this?

This is because those targets do not support atomic CAS. See also https://github.com/rust-lang/rust/pull/51953. The feature to handle this correctly on the library side is unstable, and some crates support it...

@henrikssn I have created a patch to support those targets (https://github.com/taiki-e/bytes/tree/cfg_target_has_atomic). Could you try if it solves the problem in your project? (in the way described below) 1. Add the...

@dunmatt > Is it possible to do a similar magic to allow `bytes::Bytes` to be used? atomic CAS (compare and swap) cannot be used in thumbv6m-none-eabi and `Bytes` uses it....

> If it _never_ compiled, I don't think it would be a breaking change to support `Bytes` as a `!Send` and `!Sync` type on some platforms. I don't think this...

> while the patch allows compilation it now requires nightly, doesn't it? Updated #467 to support stable Rust.

> Could using the following polyfill help in any way? > https://crates.io/crates/atomic-polyfill That is unsound on multi-core systems.