Taiki Endo

Results 935 comments of Taiki Endo

Adding a comment seems a good idea to me. I'd prefer to use a comment like "This is also available as `crossbeam::scope` and `crossbeam::thread::scope`.", as `thread::scope()` might make more sense...

This seems similar to the case mentioned in https://github.com/crossbeam-rs/crossbeam/issues/860. I said in https://github.com/crossbeam-rs/crossbeam/issues/860#issuecomment-1178511100: > Reducing MAX_OBJECTS makes it more likely to trigger any potential data races. So reverting https://github.com/crossbeam-rs/crossbeam/pull/552 may...

Thanks for confirming! I've reverted #552 as part of #879. It is difficult for me to investigate this at this time as I could not reproduce this issue in my...

This seems to be related to base::RefEntry not implementing Drop (https://github.com/crossbeam-rs/crossbeam/pull/337). Also, this only happens with SkipList, and SkipMap and SkipSet don't seem to have this problem. (https://github.com/crossbeam-rs/crossbeam/pull/674)

Hmm, if I understand correctly, there is no way actually to cause this at this time. (That said, we can do this with zero cost using RAII guards that abort...

> But there is already an [accepted RFC](https://rust-lang.github.io/rfcs/2116-alloc-me-maybe.html) for Rust to change the behaviour of out-of-memory panics to unwinding panics on user request. So when this is implemented (it may...

As said in #2259, the problem should be automatically resolved when the maintainer creates a new release using the nightly toolchain after nightly-2022-08-13 (tomorrow).

This has been fixed in 1.0.144: https://docs.rs/crate/serde/1.0.144/source/Cargo.toml

Note that this is currently only needed for the nightly compiler: https://github.com/rust-fuzz/afl.rs/pull/197