Shu-yu Guo

Results 195 comments of Shu-yu Guo

I think @ioannad would better handle it, as she's been handling @Ms2ger's previous reviews. Sorry to pass the buck. :)

> @ljharb I just like them better. preincrements are faster bro

I took a look. It's an unfortunate issue of error behavior divergence due to optimized code. tl;dr This is https://bugs.chromium.org/p/chromium/issues/detail?id=1201626, in particular [this TODO](https://source.chromium.org/chromium/chromium/src/+/main:v8/src/objects/elements.cc;l=858;drc=d05b726f47a76ceea1d620d5a8b2560c0bbc798a) In the first snippet, `const x...

Discussed this on the editor call. We're in favor of listing the instance properties with the following provisos: - Instance properties are installed by algorithmic steps in the constructor. Unlike...

> @syg would removing these tests be a problem for Chromium/V8? Do we depend on them to avoid regressions? @foolip Removing it is premature IMO. We've agreed to deprecate and...

cc @addaleax @tniessen who were the reviewers for the related PR https://github.com/nodejs/node/pull/52292

I will be proposing https://github.com/syg/proposal-atomics-microwait

> @syg has proposed a [microwait](https://github.com/tc39/proposal-atomics-microwait) primitive, which would provide a [sched_yield()](https://man7.org/linux/man-pages/man2/sched_yield.2.html) or [_mm_pause()](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_pause&ig_expand=4897) type of primitive on the web. To clarify, the microwait API as proposed is `_mm_pause`, _not_...

> @syg I know you mentioned some concerns about BigDecimal in the December Decimal update. Are optimizations such as this one on the table and would they address your concerns?...

The 262 editors discussed this, and we're not clear on the purpose or the utility of Annex F as it stands. We plan to bring this to committee to gather...