Shu-yu Guo comments

Results 264 comments of


                                            Shu-yu Guo

Stage 3 feedback: can we make the number of using decls that need disposal statically knowable?

> Why can't You can if the case bodies have their own blocks. We're complaining about bare case bodies.

Remove import assertions tests

Yep, confirm that this is good to land. After this V8 will remove code for supporting `assert`.

src: remove ArrayBufferAllocator::Reallocate override

@benjamingr I see that I got the commit message capitalization wrong. Should I force-push with the correct capitalization? I imagine that'll need a new CI run.

src: remove ArrayBufferAllocator::Reallocate override

Lowercased commit message and rebased.

src: remove ArrayBufferAllocator::Reallocate override

Ping on merging.

src: remove ArrayBufferAllocator::Reallocate override

I see a failure with `[ FAILED ] InspectorSocketTest.HostIPv6NonRoutable`. Dead code removal shouldn't cause any failures. Before I investigate further, is that a known flake to folks who regularly work...

src: remove ArrayBufferAllocator::Reallocate override

@joyeecheung Please help us land this. :)

Feature proposal: Mitigation for Client-Side Prototype Pollution

I'm not clear on why this needs to be a document policy instead of being done programmatically, if the behavior is equivalent to calling `freeze` and `preventExtensions`. Is the security...

Feature proposal: Mitigation for Client-Side Prototype Pollution

> But if we can roll out a report-only mode, we get benefit of: Can such a report-only mode be built in devtools instead of a document-policy header?

Scope of `var` in the block?

The proposal as stands radically changes the scoping + hoisting mental model around `{ }` and makes it even more confusing IMO.