Shu-yu Guo

Results 195 comments of Shu-yu Guo

Thank you for the reviews.

@ljharb Thanks for the review - I prefer to leave "promise capability" as is in both cases. - We discussed at this at the last editor meeting and you know...

I've decided to change the semantics of `Atomics.wait` to not cut the line and to keep a single per-location FIFO queue for both sync and async waiters. In light of...

The "contraction" is in the context of the original goal of supporting BigInt on existing Math operation. I take @jakobkummerow's point here to be that now you've reduced the scope,...

> Oh now I need to do this math, let's throw the data in, oh no doesn't work on BigInt, better make it a Number... The hypothesis is that that...

@ljharb @js-choi That's right, that was a narrower point for rounding functions, not every function.

The broader point isn't that no Math functions make sense and we shouldn't provide BigInt functionality for them, but that a sufficiently small enough subset does that we might still...

> In terms of evaluation ordering under TLA, as I mentioned in plenary, TLA executions can always be raced by another top-level importer, so I struggle to see how this...

lgtm % small editorial stuff we can fix up when merging into ecma262. Some editorial stuff I noticed: - I'd prefer the following pattern... ``` 1. Let _x_ be ~empty~....

I was similarly confused by this. I think even had to ask @rbuckton to explain why it's the same grammar. Definitely worth at least a note. I think on net,...