sudlud

Results 201 comments of sudlud

Looks like CI is broken right now

So what's the state of this PR now? Ready to be tested again?

I can confirm this on latest AC. I've had the mail appearing in my mailbox multiple times without ever actually being sheeped, always after a short visit to dalaran.

> What needs to be tested. Well this should actually not have any negative impact at all. It might increase cpu load slightly (maybe?) as all gameobjects beeing set active...

Testing could also be done by assigning a custom gameobject script to a gameobject, do setActive(true) inside and e.g. print a log / error message in a loop. When leaving...

> Can this cause additional load understand? Or did the translator misinterpret your words? It depends. I didn't check the whole core to see which gameobjects are set active. So...

> azerothcore has its own discord - I dont see the reason to link to 1 specific project using azerothcore. Thanks - I messed this up, the old link is...

> @55Honey can you provide a permanent link that won't expire? I grepped the new one from Azerothcore.org, might want to update that too, in this case.

On latest PRs Ubuntu nopch build fails and complains that precompiled headers need to be updated. Is this related to this PR? 👀 Edit: e.g. #18620

@0x7FFF do you want update the PR based on the pending reviews so we can get this tested and merged maybe? 🙃