sudlud

> Makes me wonder if the `is_logout_resting` column in the characters table can be retired. is_logout_resting is in use within Player::LoadFromDB() to calculate correct resting XP. https://github.com/azerothcore/azerothcore-wotlk/blob/b6ee4f49cfbfc907b91fab446de7d207a2bff8bc/src/server/game/Entities/Player/PlayerStorage.cpp#L5418-L5420 also it's beeing...

also it seems that the rest flag is beeing set, but maybe not in all sitations e.g. Player::UpdateZone() https://github.com/azerothcore/azerothcore-wotlk/blob/b6ee4f49cfbfc907b91fab446de7d207a2bff8bc/src/server/game/Entities/Player/PlayerUpdates.cpp#L1284-L1292 Player::UpdateArea(): https://github.com/azerothcore/azerothcore-wotlk/blob/b6ee4f49cfbfc907b91fab446de7d207a2bff8bc/src/server/game/Entities/Player/PlayerUpdates.cpp#L1205-L1208 Player::LoadFromDB(): https://github.com/azerothcore/azerothcore-wotlk/blob/b6ee4f49cfbfc907b91fab446de7d207a2bff8bc/src/server/game/Entities/Player/PlayerStorage.cpp#L5426-L5430

Maybe you can specify your test scenario in more detail please

I have issues reproducing this on c47c945aa I've actually gotten the aura 29519 and was able to turn in the quest on 2 of 4 tries, sometimes I didn't get...

The gameobject `181598 Silithyst Geyser` triggers spell `29518 Sillithus Flag Click (DND)` which is serverside spell implemented via `spell_dbc`. spell handling is beeing done in https://github.com/azerothcore/azerothcore-wotlk/blob/c47c945aa4200829fbe1c6b11a2cc028d3420b9b/src/server/scripts/OutdoorPvP/OutdoorPvPSI.cpp#L235-L247 and correctly applies aura...

It seems to work once after a server restart and then the "HandleCustomSpell" function is not getting called anymore 👀

Alright so the issue seems to originate in https://github.com/azerothcore/azerothcore-wotlk/blob/c47c945aa4200829fbe1c6b11a2cc028d3420b9b/src/server/game/OutdoorPvP/OutdoorPvPMgr.cpp#L173 This handles a spell from spell_dbc when it's e.g. beeing triggered by a gameobject. It loops over all known PVP areas...

Alright so this issue is caused by the function `OPvPCapturePoint::HandleCustomSpell()` in OutdoorPvP.cpp: https://github.com/azerothcore/azerothcore-wotlk/blob/c47c945aa4200829fbe1c6b11a2cc028d3420b9b/src/server/game/OutdoorPvP/OutdoorPvP.cpp#L556-L559 so in the moment the player has PVP active, this returns true which means it "handled the...

After applying the following changes, the underliying issue seems to be fixed: ```diff diff --git a/src/server/game/OutdoorPvP/OutdoorPvP.cpp b/src/server/game/OutdoorPvP/OutdoorPvP.cpp index 89a3e9f26..62f6140bc 100644 --- a/src/server/game/OutdoorPvP/OutdoorPvP.cpp +++ b/src/server/game/OutdoorPvP/OutdoorPvP.cpp @@ -555,7 +555,7 @@ bool OutdoorPvP::HandleCustomSpell(Player*...

> Should we not try to fix that boolean function instead? Wonder why it is going wrong. IsOutdoorPvPActive I mean This function is working just fine, it returns if the...