sudlud
sudlud
> At first glance, reviewing the code, it is understood that it was a possibly typing error and it is good that it be fixed. I thought you tried it....
Any feedback / issues / testing available for this PR? 🙂
> BGs are scary. Personally I don't know whether modifying the script will break any modules. Well then the modules might need to update accordingly. This PR adds blizzlike spawns...
Thanks for the PR! I feel like this should maybe be somehow combined with the "blizzlike_pvp_los" setting that is right above the new setting? Or they should feature similar names...
I thought about something like this: ```cpp if (!sWorld->getBoolConfig(CONFIG_VMAP_BLIZZLIKE_PVP_LOS)) { if (IsBattlegroundOrArena()) { ignoreFlags = VMAP::ModelIgnoreFlags::Nothing; } } if (!sWorld->getBoolConfig(CONFIG_VMAP_BLIZZLIKE_PVP_LOS_OPEN_WORLD)) { if (IsWorldMap()) { ignoreFlags = VMAP::ModelIgnoreFlags::Nothing; } } ```...
> I don`t like the name used in this config. I feel like it describes what it does poorly as mentioned above, my suggestion would be `CONFIG_VMAP_BLIZZLIKE_PVP_LOS_OPEN_WORLD` similiar to the...
> At the time when we discussed it, and they presented the idea to me, they told me that it was not something blizzlike. That we could add it as...
> > ## Merge state > > Add more commits by pushing to the `[los](/pangolp/azerothcore-wotlk/tree/los)` branch on [pangolp/azerothcore-wotlk](/pangolp/azerothcore-wotlk). > > It's just that it's not blizzlike, that's why I didn't...
> In this case it doesn't affect PvP only and also affects creature casting iirc. Mobs will also be able to cast through trees etc. What name would you suggest...
Looks good to me. Can't really test it right now unfortunately, maybe someone else can give this a test please?