feat(CI): rework core ubuntu build, ubuntu-22 support

[michaeldelago]

Changes Proposed:

This PR proposes changes to:

• [ ] Core (units, players, creatures, game systems).
• [ ] Scripts (bosses, spell scripts, creature scripts).
• [ ] Database (SAI, creatures, etc).
• [x] CI

This pull request reworks the "core_build" CI to:

• both PCH and no-PCH builds are executed for the latest clang and GCC versions for both ubuntu 20 and 22
• remove layers of abstraction in the CI process
  • At the moment, the CI process calls scripts in apps/ci/ when then calls further shell scripts distributed in the apps dir
  • CI that runs scripts that in turn runs scripts can make it difficult to make changes and to recognize the scope of changes
  • This PR aims to reduce some of that complexity by directly running commands as opposed to through abstractions

Issues Addressed:

• Supersedes https://github.com/azerothcore/azerothcore-wotlk/pull/17096

SOURCE:

The changes have been validated through:

• [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• [ ] Sniffs (remember to share them with the open source community!)
• [ ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [ ] Tested in-game by the author.
• [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
• [x] This pull request requires further testing and may have edge cases to be tested.

CI is one of the most tedious things to test :upside_down_face:

How to Test the Changes:

• [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
• [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. run the ci

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Kitzunu]

Havent checked it yet. But make sure that the modules build dont run by default

[Kitzunu]

Why was ubuntu-build skipped here?

[michaeldelago]

I completely forgot about this PR and life had a bunch of stuff going on

Will be re-visiting it this weekend

[Kitzunu]

hows it going

[michaeldelago]

oh there's actually a bug in github actions lol

https://github.com/actions/runner-images/issues/8659

[michaeldelago]

this has FINALLY been properly updated and put into a working state.

I've updated the description of the PR to help describe changes being made in the PR.

[FrancescoBorzi]

excellent work @michaeldelago

[elthehablo]

just checking if this is still good to merge as we speak?

[michaeldelago]

Bah, I thought this got merged. It should be good to do so unless something has changed.

I'm out of the country at the moment, I'll wait until I return to merge in case it needs babysitting. Anyone else, feel free to merge if they'd like.

On Sun, Mar 24, 2024, 4:13 PM Dan @.***> wrote:

just checking if this is still good to merge as we speak?

— Reply to this email directly, view it on GitHub https://github.com/azerothcore/azerothcore-wotlk/pull/17281#issuecomment-2016840555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2CPHN34MIJ3CORL4UIBCLYZ3UQ5AVCNFSM6AAAAAA43LANTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHA2DANJVGU . You are receiving this because you were mentioned.Message ID: @.***>

[elthehablo]

Bah, I thought this got merged. It should be good to do so unless something has changed.

I'm out of the country at the moment, I'll wait until I return to merge in case it needs babysitting. Anyone else, feel free to merge if they'd like.

On Sun, Mar 24, 2024, 4:13 PM Dan @.***> wrote:

just checking if this is still good to merge as we speak?

— Reply to this email directly, view it on GitHub https://github.com/azerothcore/azerothcore-wotlk/pull/17281#issuecomment-2016840555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2CPHN34MIJ3CORL4UIBCLYZ3UQ5AVCNFSM6AAAAAA43LANTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHA2DANJVGU . You are receiving this because you were mentioned.Message ID: @.***>

Gotcha thanks for the reply

[pangolp]

Are we in a position to merge this?

[sudlud]

On latest PRs Ubuntu nopch build fails and complains that precompiled headers need to be updated.

Is this related to this PR? 👀

Edit: e.g. #18620

[pangolp]

On latest PRs Ubuntu nopch build fails and complains that precompiled headers need to be updated.

Is this related to this PR? 👀

The truth is I don't know.