stuartmorgan

Results 843 comments of stuartmorgan

FYI, the "conversion" from `std::string` to `std::wstring` on line 104 will not work if there is any unicode in the path. I would recommend using `std::filesystem::u8path` to construct a path...

I am planning to look at adapting this to the current state of the plugins once the iOS conversion to Dart+Pigeon is complete.

The Dart conversion is complete, but in the meantime we found https://github.com/flutter/flutter/issues/94051 which blocks this, since we currently `implement` `WebViewPlatformCallbacksHandler` in our implementations, making changes to it breaking changes. We're...

Status update from triage: this is still blocked, but we hope to have it unblocked soon.

@camsim99 Since you are looking at `local_auth` at the moment, maybe you could do the initial review here?

What's the status of this PR? It's not clear to me if all of the last round of review comments have been addressed yet, and it looks like some of...