plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[webview_flutter] Send history events

Open wwwdata opened this issue 4 years ago • 12 comments

Description

Send URL change events when the user navigates in the Browser. This also works for JavaScript Navigation that does not actually make any request and therefore would not trigger page load or finish events.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x] All existing and new tests are passing.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] The analyzer (flutter analyze) does not report any problems on my PR.
  • [x] I read and followed the Flutter Style Guide.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [x] I updated CHANGELOG.md to add a description of the change.
  • [x] I signed the CLA.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [x] No, this is not a breaking change.

wwwdata avatar Dec 09 '19 11:12 wwwdata

hi @wwwdata could you please rebase (& start the next version number)

ened avatar Dec 10 '19 09:12 ened

hi @wwwdata could you please rebase (& start the next version number)

Just rebased, increased version number and pushed. Thanks for the fast feedback

wwwdata avatar Dec 10 '19 12:12 wwwdata

@ened Thanks a lot for the good review feedback. Implemented the requested changes.

wwwdata avatar Dec 10 '19 13:12 wwwdata

Hi @wwwdata, is this pull request still active ? I also need this implementation, and see that's it is an old PR. I see that it requires @amirh approval, any update on this feature ? Thanks.

MattisBrizard avatar Oct 12 '20 10:10 MattisBrizard

So far I didn't hear anything official... I would be happy to rebase and fix all conflicts here again if somebody then also does a review...

wwwdata avatar Oct 12 '20 10:10 wwwdata

Ok, it's rebased again. We're only in 10 months waiting for a review, so let's give it some time :)

wwwdata avatar Oct 13 '20 13:10 wwwdata

This would be a great feature to have :)

jcgoodru avatar Jan 04 '21 22:01 jcgoodru

@wwwdata Any chance you have the time to look at this again? It looks like it's so close to landing.

Hixie avatar Oct 26 '21 23:10 Hixie

I am going to close this as stale. Feel free to re-open if you are going to rebase and apply requested changes.

christopherfujino avatar Mar 09 '22 00:03 christopherfujino

I am planning to look at adapting this to the current state of the plugins once the iOS conversion to Dart+Pigeon is complete.

stuartmorgan avatar Mar 09 '22 02:03 stuartmorgan

The Dart conversion is complete, but in the meantime we found https://github.com/flutter/flutter/issues/94051 which blocks this, since we currently implement WebViewPlatformCallbacksHandler in our implementations, making changes to it breaking changes. We're actively working on that issue, and hope to have it resolved soon.

stuartmorgan avatar Jul 28 '22 20:07 stuartmorgan

Status update from triage: this is still blocked, but we hope to have it unblocked soon.

stuartmorgan avatar Aug 30 '22 15:08 stuartmorgan

This is unblocked now that v4 has landed. @bparrishMines This is one we should look at updating.

stuartmorgan avatar Jan 11 '23 19:01 stuartmorgan

Closing as this was obsoleted by https://github.com/flutter/plugins/pull/7113; the implementation had changed enough that it was easiest to start a new PR rather than update this one. Thanks!

stuartmorgan avatar Feb 14 '23 20:02 stuartmorgan