plugins
plugins copied to clipboard
[local_auth] Fixes show dialog when biometrics is not enrolled on Android devices.
Description
- Added AuthenticationErrorHandler class to encapsulate error handling logic which can be reused in several places. It can help to avoid applying different error processing logic for same kind of errors in different places.
- Added AuthResultErrorCodes class containing result error codes constants. These error codes are matching to those in error_codes.dart.
Related issues
https://github.com/flutter/flutter/issues/96646
Pre-launch Checklist
- [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [X] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [X] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use
dart format
.) - [X] I signed the CLA.
- [X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.
[shared_preferences]
- [X] I listed at least one issue that this PR fixes in the description above.
- [X] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [X] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [X] I updated/added relevant documentation (doc comments with
///
). - [X] I added new tests to check the change I am making, or this PR is test-exempt.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
@camsim99 Since you are looking at local_auth
at the moment, maybe you could do the initial review here?
What's the status of this PR? It's not clear to me if all of the last round of review comments have been addressed yet, and it looks like some of the tests don't compile.
Closing this PR since the issue is not reproducing in local_auth 2.1.2. Further refactoring is not seems to be directly related to this issue.