Istvan Toth

Results 504 comments of Istvan Toth

The Jenkins/Yetus changes in my PR are very WIP, not sure they are worth including here yet, @jojochuang . I hope to have them polished by next week.

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 3m 1s | Docker mode activated. | ||| _ Prechecks _...

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 9s | Docker mode activated. | ||| _ Prechecks _...

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 12s | Docker mode activated. | ||| _ Prechecks _...

Yes, I mean the behaviour before your patch.

Please rename the ticket and patch something more descriptive, like 'Add option not to add CF to the Spark Column name in Spark Connector'

You can squash and force-push your changes with the updated commit message.

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 11s | Docker mode activated. | ||| _ Prechecks _...

Two general comments: The description is too generic. SecurityManager is used in other places, mainly via HAdoop/UGI, which this patch does not fix. I suggest rewording it to reflect that...