Istvan Toth

Results 504 comments of Istvan Toth

Hadoop uses similar ExitHandler mechanism(s). We're doing something very similar (Replacing remaining SecurtityManager usages for system.exit) in Hadoop for 3.5. But you're right in that Hadoop should expose this functionality...

The approach here is directly lifted from Jetty (pruning some unused functions)

I have applied your PR, and made some minor changes. These are in different commits. Please check them @chrisdennis .

I have changed the name back to sneakyThrow(). Since we're going for perfection, we may also want to reconsider callAs(). Subject callAs() throws Exceptions, and the fallback path now also...

> I'm confused, Subject.callAs(...) throws `CompletionException` if the action throws, which is what the current code does, unwrapping any PrivilegedActionException and rewrapping it in case we're backed by the old...

This is as polished as it gets now. Can you do a final review @zabetak ?

Merged manually. (Maybe we could enable squash merges...)