Istvan Toth

Results 504 comments of Istvan Toth

I have added tests for SPNEGO authentication for Squid. I feel that this is ready now, @michael-o .

I can do that, but that would mean the the three formerly mutual classes only differ in case and package from the old deprecated classes. I can see that causing...

Thanks for the review. I have made the suggested changes, but I am not happy with how close the old new class names are. I have also left KerberosCredentials alone,...

> > I can do that, but then then the only difference between the old and new classes will be the packages and the case. Machines don't care, but I...

I have fixed the small issues. It's getting late, I'll try to do the loop condition tomorrow.

I have added a new config option for non-standard servers, and rewritten the established checks. Please take another look @michael-o .

I have split the mutual auth config option to request and require. Having both takes no effort on our part, but allows for set and pray mutual authentication (though I...

I opened https://bugs.squid-cache.org/show_bug.cgi?id=5485 for the Squid issues.

I realize that I somehow didn't upload the changes for GSSSchemeBase in my last pach, that's why a lot of your earlier comments were not addressed.

I hope I got all the fixes we discussed, @michael-o . Based on my digging, I have set isConnectionBased() to false. I have also fixed the logic in the needAuthentication()...