phoenix-connectors icon indicating copy to clipboard operation
phoenix-connectors copied to clipboard

PHOENIX-7377 phoenix5-spark dataframe issue with schema inference

Open rejeb opened this issue 1 year ago • 2 comments

The PR add a flag to fix the PHOENIX-7377 issue.

  • Add a flag escapeColumnFamily default to false.
  • Make SparkSchemaUtil.normalizeColumnName and SparkSchemaUtil.phoenixTypeToCatalystType private since they are used exclusively in SparkSchemaUtil.
  • Update README.

rejeb avatar Jul 29 '24 07:07 rejeb

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 3m 1s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 11m 23s Maven dependency ordering for branch
-1 :x: mvninstall 0m 7s root in master failed.
-1 :x: compile 0m 7s phoenix5-spark in master failed.
-1 :x: compile 0m 7s phoenix5-spark3 in master failed.
+1 :green_heart: checkstyle 0m 25s master passed
-1 :x: javadoc 0m 7s phoenix5-spark in master failed.
-1 :x: javadoc 0m 7s phoenix5-spark3 in master failed.
-1 :x: scaladoc 0m 6s phoenix5-spark in master failed.
-1 :x: scaladoc 0m 7s phoenix5-spark3 in master failed.
-1 :x: spotbugs 0m 6s phoenix5-spark in master failed.
-1 :x: spotbugs 0m 7s phoenix5-spark3 in master failed.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 5s Maven dependency ordering for patch
-1 :x: mvninstall 0m 5s root in the patch failed.
-1 :x: compile 0m 7s phoenix5-spark in the patch failed.
-1 :x: compile 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: javac 0m 7s phoenix5-spark in the patch failed.
-1 :x: javac 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: scalac 0m 7s phoenix5-spark in the patch failed.
-1 :x: scalac 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: checkstyle 0m 6s phoenix5-spark: The patch generated 1 new + 18 unchanged - 0 fixed = 19 total (was 18)
-1 :x: checkstyle 0m 6s phoenix5-spark3: The patch generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)
-1 :x: markdownlint 0m 3s The patch generated 11 new + 101 unchanged - 0 fixed = 112 total (was 101)
-1 :x: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 :x: javadoc 0m 7s phoenix5-spark in the patch failed.
-1 :x: javadoc 0m 7s phoenix5-spark3 in the patch failed.
-1 :x: scaladoc 0m 7s phoenix5-spark in the patch failed.
-1 :x: scaladoc 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: spotbugs 0m 6s phoenix5-spark in the patch failed.
-1 :x: spotbugs 0m 7s phoenix5-spark3 in the patch failed.
_ Other Tests _
-1 :x: unit 0m 6s phoenix5-spark in the patch failed.
-1 :x: unit 0m 6s phoenix5-spark3 in the patch failed.
+1 :green_heart: asflicense 0m 15s The patch does not generate ASF License warnings.
17m 52s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/134
Optional Tests dupname asflicense markdownlint javac javadoc unit spotbugs hbaseanti checkstyle compile scalac scaladoc
uname Linux 136bafce571b 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4c880e2
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/whitespace-eol.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-spark phoenix5-spark3 U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/1/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jul 29 '24 07:07 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 9s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 10m 33s Maven dependency ordering for branch
-1 :x: mvninstall 0m 7s root in master failed.
-1 :x: compile 0m 7s phoenix5-spark in master failed.
-1 :x: compile 0m 7s phoenix5-spark3 in master failed.
+1 :green_heart: checkstyle 0m 24s master passed
-1 :x: javadoc 0m 7s phoenix5-spark in master failed.
-1 :x: javadoc 0m 7s phoenix5-spark3 in master failed.
-1 :x: scaladoc 0m 6s phoenix5-spark in master failed.
-1 :x: scaladoc 0m 7s phoenix5-spark3 in master failed.
-1 :x: spotbugs 0m 7s phoenix5-spark in master failed.
-1 :x: spotbugs 0m 6s phoenix5-spark3 in master failed.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 6s Maven dependency ordering for patch
-1 :x: mvninstall 0m 5s root in the patch failed.
-1 :x: compile 0m 7s phoenix5-spark in the patch failed.
-1 :x: compile 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: javac 0m 7s phoenix5-spark in the patch failed.
-1 :x: javac 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: scalac 0m 7s phoenix5-spark in the patch failed.
-1 :x: scalac 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: checkstyle 0m 6s phoenix5-spark: The patch generated 1 new + 18 unchanged - 0 fixed = 19 total (was 18)
-1 :x: checkstyle 0m 6s phoenix5-spark3: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
-1 :x: markdownlint 0m 3s The patch generated 11 new + 101 unchanged - 0 fixed = 112 total (was 101)
-1 :x: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 :x: javadoc 0m 7s phoenix5-spark in the patch failed.
-1 :x: javadoc 0m 7s phoenix5-spark3 in the patch failed.
-1 :x: scaladoc 0m 7s phoenix5-spark in the patch failed.
-1 :x: scaladoc 0m 6s phoenix5-spark3 in the patch failed.
-1 :x: spotbugs 0m 6s phoenix5-spark in the patch failed.
-1 :x: spotbugs 0m 7s phoenix5-spark3 in the patch failed.
_ Other Tests _
-1 :x: unit 0m 6s phoenix5-spark in the patch failed.
-1 :x: unit 0m 7s phoenix5-spark3 in the patch failed.
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
14m 9s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/134
Optional Tests dupname asflicense markdownlint javac javadoc unit spotbugs hbaseanti checkstyle compile scalac scaladoc
uname Linux bfb880a6fb01 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4c880e2
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/whitespace-eol.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-spark phoenix5-spark3 U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/2/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jul 29 '24 08:07 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 12s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 10m 41s Maven dependency ordering for branch
-1 :x: mvninstall 0m 8s root in master failed.
-1 :x: compile 0m 9s phoenix5-spark in master failed.
-1 :x: compile 0m 9s phoenix5-spark3 in master failed.
+1 :green_heart: checkstyle 0m 32s master passed
-1 :x: javadoc 0m 9s phoenix5-spark in master failed.
-1 :x: javadoc 0m 9s phoenix5-spark3 in master failed.
-1 :x: scaladoc 0m 9s phoenix5-spark in master failed.
-1 :x: scaladoc 0m 9s phoenix5-spark3 in master failed.
-1 :x: spotbugs 0m 9s phoenix5-spark in master failed.
-1 :x: spotbugs 0m 9s phoenix5-spark3 in master failed.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for patch
-1 :x: mvninstall 0m 6s root in the patch failed.
-1 :x: compile 0m 9s phoenix5-spark in the patch failed.
-1 :x: compile 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: javac 0m 9s phoenix5-spark in the patch failed.
-1 :x: javac 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: scalac 0m 9s phoenix5-spark in the patch failed.
-1 :x: scalac 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: checkstyle 0m 9s phoenix5-spark: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
-1 :x: checkstyle 0m 9s phoenix5-spark3: The patch generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-1 :x: markdownlint 0m 4s The patch generated 11 new + 101 unchanged - 0 fixed = 112 total (was 101)
-1 :x: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 :x: javadoc 0m 9s phoenix5-spark in the patch failed.
-1 :x: javadoc 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: scaladoc 0m 9s phoenix5-spark in the patch failed.
-1 :x: scaladoc 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: spotbugs 0m 9s phoenix5-spark in the patch failed.
-1 :x: spotbugs 0m 9s phoenix5-spark3 in the patch failed.
_ Other Tests _
-1 :x: unit 0m 9s phoenix5-spark in the patch failed.
-1 :x: unit 0m 8s phoenix5-spark3 in the patch failed.
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
15m 29s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/134
Optional Tests dupname asflicense markdownlint javac javadoc unit spotbugs hbaseanti checkstyle compile scalac scaladoc
uname Linux 7e398d0d21cd 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4c880e2
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/whitespace-eol.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-spark phoenix5-spark3 U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/3/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Aug 13 '24 14:08 stoty

Thank you for the review, Juste a question please, I have a doubt, whith "new behavior" you mean having column family name in spark dataframe column name ?

rejeb avatar Aug 13 '24 16:08 rejeb

Yes, I mean the behaviour before your patch.

stoty avatar Aug 13 '24 16:08 stoty

I agree with you, the patch is to fix the issue but also to document the new behavior and add more flexibility in using the spark-phoenix connector.

Please let me now when it is ok for the review. I'll squash the commits in order to have one commit to merge.

Question, is there an opened issue to remove code duplication and deprecated classes in spark modules ? I can help doing it.

rejeb avatar Aug 13 '24 17:08 rejeb

Please rename the ticket and patch something more descriptive, like

'Add option not to add CF to the Spark Column name in Spark Connector'

stoty avatar Aug 15 '24 08:08 stoty

You can squash and force-push your changes with the updated commit message.

stoty avatar Aug 15 '24 08:08 stoty

Done, thank you for the review.

rejeb avatar Aug 15 '24 08:08 rejeb

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 11s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 10m 46s Maven dependency ordering for branch
-1 :x: mvninstall 0m 8s root in master failed.
-1 :x: compile 0m 8s phoenix5-spark in master failed.
-1 :x: compile 0m 9s phoenix5-spark3 in master failed.
+1 :green_heart: checkstyle 0m 30s master passed
-1 :x: javadoc 0m 9s phoenix5-spark in master failed.
-1 :x: javadoc 0m 10s phoenix5-spark3 in master failed.
-1 :x: scaladoc 0m 9s phoenix5-spark in master failed.
-1 :x: scaladoc 0m 9s phoenix5-spark3 in master failed.
-1 :x: spotbugs 0m 8s phoenix5-spark in master failed.
-1 :x: spotbugs 0m 9s phoenix5-spark3 in master failed.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 6s root in the patch failed.
-1 :x: compile 0m 9s phoenix5-spark in the patch failed.
-1 :x: compile 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: javac 0m 9s phoenix5-spark in the patch failed.
-1 :x: javac 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: scalac 0m 9s phoenix5-spark in the patch failed.
-1 :x: scalac 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: checkstyle 0m 9s phoenix5-spark: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
-1 :x: checkstyle 0m 9s phoenix5-spark3: The patch generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-1 :x: markdownlint 0m 2s The patch generated 11 new + 101 unchanged - 0 fixed = 112 total (was 101)
-1 :x: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 :x: javadoc 0m 9s phoenix5-spark in the patch failed.
-1 :x: javadoc 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: scaladoc 0m 9s phoenix5-spark in the patch failed.
-1 :x: scaladoc 0m 9s phoenix5-spark3 in the patch failed.
-1 :x: spotbugs 0m 8s phoenix5-spark in the patch failed.
-1 :x: spotbugs 0m 9s phoenix5-spark3 in the patch failed.
_ Other Tests _
-1 :x: unit 0m 9s phoenix5-spark in the patch failed.
-1 :x: unit 0m 8s phoenix5-spark3 in the patch failed.
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
15m 33s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/134
Optional Tests dupname asflicense markdownlint javac javadoc unit spotbugs hbaseanti checkstyle compile scalac scaladoc
uname Linux 2aceed8ceef9 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4c880e2
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
scalac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/whitespace-eol.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt
scaladoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-spark phoenix5-spark3 U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Aug 15 '24 09:08 stoty