hbase
hbase copied to clipboard
apache
HBASE-27594 [JDK17] SecurityManager is deprecated since JDK17
- Adds a custom
ExitHandlerto wrapSystem.exitcalls, preventing JVM termination during tests and throwing an exception instead. - Replaces all usages of
System.exitcalls withExitHandler.getInstance().exit. - Removes
TestSecurityManagerto reduce deprecated security manager usage. - Updates
SystemExitRuleto useExitHandlerfor controlled exit behavior. - Removes all usages of
System.setSecurityManager/System.getSecurityManagerusages in HBase so that it makes our path to future JDK upgrades easier - Eliminates warnings related to deprecated
System.setSecurityManagerandSystem.getSecurityManagercalls.WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule (file:/Users/nihaljain/code/os/hbase/hbase-common/target/test-classes/) WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule WARNING: System::setSecurityManager will be removed in a future release
This is a simple attempt to get rid of System.setSecurityManager / System.getSecurityManager usages in hbase so that it makes our path to future JDK upgrades easier! Lets see what CI says.
Built code locally, started a standalone hbase cluster and verified exit codes for HBaseConfTool are as expected.
Screenshot:
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 59s | master passed | |
| +1 :green_heart: | compile | 12m 59s | master passed | |
| +1 :green_heart: | checkstyle | 1m 23s | master passed | |
| +1 :green_heart: | spotbugs | 11m 34s | master passed | |
| +1 :green_heart: | spotless | 0m 55s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 3m 47s | the patch passed | |
| +1 :green_heart: | compile | 12m 59s | the patch passed | |
| +1 :green_heart: | javac | 0m 10s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | javac | 0m 47s | hbase-common generated 0 new + 67 unchanged - 5 fixed = 67 total (was 72) | |
| +1 :green_heart: | javac | 0m 55s | hbase-client in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-zookeeper generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) | |
| +1 :green_heart: | javac | 0m 21s | hbase-replication in the patch passed. | |
| +1 :green_heart: | javac | 0m 29s | hbase-http in the patch passed. | |
| +1 :green_heart: | javac | 0m 30s | hbase-procedure in the patch passed. | |
| -0 :warning: | javac | 3m 30s | /results-compile-javac-hbase-server.txt | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) |
| -0 :warning: | javac | 0m 45s | /results-compile-javac-hbase-mapreduce.txt | hbase-mapreduce generated 2 new + 196 unchanged - 2 fixed = 198 total (was 198) |
| +1 :green_heart: | javac | 0m 35s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | javac | 0m 56s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | javac | 0m 28s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | javac | 0m 35s | hbase-backup in the patch passed. | |
| +1 :green_heart: | javac | 0m 36s | hbase-it in the patch passed. | |
| +1 :green_heart: | javac | 0m 41s | hbase-rest in the patch passed. | |
| +1 :green_heart: | javac | 0m 31s | hbase-examples generated 0 new + 8 unchanged - 5 fixed = 8 total (was 13) | |
| +1 :green_heart: | javac | 0m 23s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | javac | 0m 23s | hbase-compression-zstd in the patch passed. | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 1m 24s | /results-checkstyle-root.txt | root: The patch generated 2 new + 165 unchanged - 1 fixed = 167 total (was 166) |
| +1 :green_heart: | xmllint | 0m 0s | No new issues. | |
| +1 :green_heart: | spotbugs | 14m 5s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 12m 55s | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | |
| +1 :green_heart: | spotless | 0m 55s | patch has no errors when running spotless:check. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 2m 50s | The patch does not generate ASF License warnings. | |
| 92m 54s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6932 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint |
| uname | Linux 6fd14ade36ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 20fc7b06a0fb3423f87b294666c79a07038fd65e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-diagnostics hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 17m 12s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 5m 13s | master passed | |
| +1 :green_heart: | compile | 8m 55s | master passed | |
| +1 :green_heart: | javadoc | 6m 51s | master passed | |
| +1 :green_heart: | shadedjars | 8m 5s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 7m 16s | the patch passed | |
| +1 :green_heart: | compile | 9m 1s | the patch passed | |
| +1 :green_heart: | javac | 0m 14s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | javac | 0m 30s | hbase-common generated 0 new + 3 unchanged - 9 fixed = 3 total (was 12) | |
| +1 :green_heart: | javac | 0m 33s | hbase-client in the patch passed. | |
| +1 :green_heart: | javac | 0m 26s | hbase-zookeeper generated 0 new + 3 unchanged - 2 fixed = 3 total (was 5) | |
| +1 :green_heart: | javac | 0m 22s | hbase-replication in the patch passed. | |
| +1 :green_heart: | javac | 0m 26s | hbase-http in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-procedure in the patch passed. | |
| +1 :green_heart: | javac | 1m 20s | hbase-server generated 0 new + 13 unchanged - 6 fixed = 13 total (was 19) | |
| +1 :green_heart: | javac | 0m 29s | hbase-mapreduce generated 0 new + 0 unchanged - 24 fixed = 0 total (was 24) | |
| +1 :green_heart: | javac | 0m 26s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | javac | 0m 38s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | javac | 0m 27s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | javac | 0m 28s | hbase-backup in the patch passed. | |
| +1 :green_heart: | javac | 0m 28s | hbase-it in the patch passed. | |
| +1 :green_heart: | javac | 0m 36s | hbase-rest in the patch passed. | |
| +1 :green_heart: | javac | 0m 28s | hbase-examples generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5) | |
| +1 :green_heart: | javac | 0m 22s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-compression-zstd in the patch passed. | |
| +1 :green_heart: | javadoc | 6m 45s | the patch passed | |
| +1 :green_heart: | shadedjars | 8m 33s | patch has no errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 0m 17s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | unit | 4m 23s | hbase-common in the patch passed. | |
| +1 :green_heart: | unit | 2m 48s | hbase-client in the patch passed. | |
| +1 :green_heart: | unit | 1m 55s | hbase-zookeeper in the patch passed. | |
| +1 :green_heart: | unit | 5m 42s | hbase-replication in the patch passed. | |
| +1 :green_heart: | unit | 2m 0s | hbase-http in the patch passed. | |
| +1 :green_heart: | unit | 1m 58s | hbase-procedure in the patch passed. | |
| -1 :x: | unit | 330m 7s | /patch-unit-hbase-server.txt | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 22m 37s | hbase-mapreduce in the patch passed. | |
| +1 :green_heart: | unit | 5m 17s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | unit | 6m 52s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | unit | 3m 58s | hbase-endpoint in the patch passed. | |
| -1 :x: | unit | 16m 7s | /patch-unit-hbase-backup.txt | hbase-backup in the patch failed. |
| +1 :green_heart: | unit | 0m 56s | hbase-it in the patch passed. | |
| +1 :green_heart: | unit | 4m 29s | hbase-rest in the patch passed. | |
| +1 :green_heart: | unit | 2m 21s | hbase-examples in the patch passed. | |
| +1 :green_heart: | unit | 0m 46s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | unit | 4m 34s | hbase-compression-zstd in the patch passed. | |
| 505m 58s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6932 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux d5865e92261d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 20fc7b06a0fb3423f87b294666c79a07038fd65e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/2/testReport/ |
| Max. process+thread count | 4574 (vs. ulimit of 30000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-diagnostics hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 4m 30s | master passed | |
| +1 :green_heart: | compile | 14m 54s | master passed | |
| +1 :green_heart: | checkstyle | 1m 18s | master passed | |
| +1 :green_heart: | spotbugs | 11m 2s | master passed | |
| +1 :green_heart: | spotless | 0m 49s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 3m 24s | the patch passed | |
| +1 :green_heart: | compile | 13m 52s | the patch passed | |
| +1 :green_heart: | javac | 0m 9s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | javac | 0m 42s | hbase-common generated 0 new + 67 unchanged - 5 fixed = 67 total (was 72) | |
| +1 :green_heart: | javac | 0m 52s | hbase-client in the patch passed. | |
| +1 :green_heart: | javac | 0m 29s | hbase-zookeeper generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) | |
| +1 :green_heart: | javac | 0m 31s | hbase-replication in the patch passed. | |
| +1 :green_heart: | javac | 0m 37s | hbase-http in the patch passed. | |
| +1 :green_heart: | javac | 0m 31s | hbase-procedure in the patch passed. | |
| -0 :warning: | javac | 3m 46s | /results-compile-javac-hbase-server.txt | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) |
| -0 :warning: | javac | 0m 46s | /results-compile-javac-hbase-mapreduce.txt | hbase-mapreduce generated 2 new + 196 unchanged - 2 fixed = 198 total (was 198) |
| +1 :green_heart: | javac | 0m 32s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | javac | 1m 0s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | javac | 0m 32s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | javac | 0m 39s | hbase-backup in the patch passed. | |
| +1 :green_heart: | javac | 0m 37s | hbase-it in the patch passed. | |
| +1 :green_heart: | javac | 0m 44s | hbase-rest in the patch passed. | |
| +1 :green_heart: | javac | 0m 37s | hbase-examples generated 0 new + 8 unchanged - 5 fixed = 8 total (was 13) | |
| +1 :green_heart: | javac | 0m 25s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | javac | 0m 23s | hbase-compression-zstd in the patch passed. | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 1m 31s | /results-checkstyle-root.txt | root: The patch generated 3 new + 164 unchanged - 2 fixed = 167 total (was 166) |
| +1 :green_heart: | xmllint | 0m 0s | No new issues. | |
| +1 :green_heart: | spotbugs | 14m 19s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 13m 58s | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | |
| +1 :green_heart: | spotless | 1m 1s | patch has no errors when running spotless:check. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 4m 8s | The patch does not generate ASF License warnings. | |
| 97m 42s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6932 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint |
| uname | Linux 5d73943c2f31 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 20fc7b06a0fb3423f87b294666c79a07038fd65e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 85 (vs. ulimit of 30000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-diagnostics hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/3/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 4m 7s | master passed | |
| +1 :green_heart: | compile | 7m 36s | master passed | |
| +1 :green_heart: | javadoc | 5m 41s | master passed | |
| +1 :green_heart: | shadedjars | 7m 10s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 4m 0s | the patch passed | |
| +1 :green_heart: | compile | 6m 51s | the patch passed | |
| +1 :green_heart: | javac | 0m 9s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | javac | 0m 23s | hbase-common generated 0 new + 3 unchanged - 9 fixed = 3 total (was 12) | |
| +1 :green_heart: | javac | 0m 23s | hbase-client in the patch passed. | |
| +1 :green_heart: | javac | 0m 16s | hbase-zookeeper generated 0 new + 3 unchanged - 2 fixed = 3 total (was 5) | |
| +1 :green_heart: | javac | 0m 14s | hbase-replication in the patch passed. | |
| +1 :green_heart: | javac | 0m 20s | hbase-http in the patch passed. | |
| +1 :green_heart: | javac | 0m 16s | hbase-procedure in the patch passed. | |
| +1 :green_heart: | javac | 1m 1s | hbase-server generated 0 new + 13 unchanged - 6 fixed = 13 total (was 19) | |
| +1 :green_heart: | javac | 0m 23s | hbase-mapreduce generated 0 new + 0 unchanged - 24 fixed = 0 total (was 24) | |
| +1 :green_heart: | javac | 0m 20s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | javac | 0m 27s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | javac | 0m 19s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-backup in the patch passed. | |
| +1 :green_heart: | javac | 0m 28s | hbase-it in the patch passed. | |
| +1 :green_heart: | javac | 0m 31s | hbase-rest in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-examples generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5) | |
| +1 :green_heart: | javac | 0m 15s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | javac | 0m 18s | hbase-compression-zstd in the patch passed. | |
| +1 :green_heart: | javadoc | 4m 49s | the patch passed | |
| +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 0m 12s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | unit | 2m 35s | hbase-common in the patch passed. | |
| +1 :green_heart: | unit | 1m 45s | hbase-client in the patch passed. | |
| +1 :green_heart: | unit | 0m 46s | hbase-zookeeper in the patch passed. | |
| +1 :green_heart: | unit | 0m 27s | hbase-replication in the patch passed. | |
| +1 :green_heart: | unit | 0m 58s | hbase-http in the patch passed. | |
| +1 :green_heart: | unit | 1m 34s | hbase-procedure in the patch passed. | |
| +1 :green_heart: | unit | 284m 16s | hbase-server in the patch passed. | |
| +1 :green_heart: | unit | 24m 35s | hbase-mapreduce in the patch passed. | |
| +1 :green_heart: | unit | 4m 42s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | unit | 6m 49s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | unit | 3m 39s | hbase-endpoint in the patch passed. | |
| -1 :x: | unit | 16m 2s | /patch-unit-hbase-backup.txt | hbase-backup in the patch failed. |
| +1 :green_heart: | unit | 0m 54s | hbase-it in the patch passed. | |
| +1 :green_heart: | unit | 3m 51s | hbase-rest in the patch passed. | |
| +1 :green_heart: | unit | 1m 54s | hbase-examples in the patch passed. | |
| +1 :green_heart: | unit | 0m 42s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | unit | 3m 59s | hbase-compression-zstd in the patch passed. | |
| 416m 29s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6932 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux c6223ffbbbee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 20fc7b06a0fb3423f87b294666c79a07038fd65e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/3/testReport/ |
| Max. process+thread count | 5040 (vs. ulimit of 30000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-diagnostics hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/3/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 13s | master passed | |
| +1 :green_heart: | compile | 10m 45s | master passed | |
| +1 :green_heart: | checkstyle | 1m 15s | master passed | |
| +1 :green_heart: | spotbugs | 9m 8s | master passed | |
| +1 :green_heart: | spotless | 0m 46s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 3m 2s | the patch passed | |
| +1 :green_heart: | compile | 10m 38s | the patch passed | |
| +1 :green_heart: | javac | 0m 8s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | javac | 0m 39s | hbase-common generated 0 new + 67 unchanged - 5 fixed = 67 total (was 72) | |
| +1 :green_heart: | javac | 0m 45s | hbase-client in the patch passed. | |
| +1 :green_heart: | javac | 0m 20s | hbase-zookeeper generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) | |
| +1 :green_heart: | javac | 0m 18s | hbase-replication in the patch passed. | |
| +1 :green_heart: | javac | 0m 23s | hbase-http in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-procedure in the patch passed. | |
| -0 :warning: | javac | 3m 6s | /results-compile-javac-hbase-server.txt | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) |
| -0 :warning: | javac | 0m 34s | /results-compile-javac-hbase-mapreduce.txt | hbase-mapreduce generated 2 new + 196 unchanged - 2 fixed = 198 total (was 198) |
| +1 :green_heart: | javac | 0m 25s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | javac | 0m 41s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | javac | 0m 28s | hbase-backup in the patch passed. | |
| +1 :green_heart: | javac | 0m 30s | hbase-it in the patch passed. | |
| +1 :green_heart: | javac | 0m 32s | hbase-rest in the patch passed. | |
| +1 :green_heart: | javac | 0m 24s | hbase-examples generated 0 new + 8 unchanged - 5 fixed = 8 total (was 13) | |
| +1 :green_heart: | javac | 0m 20s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | javac | 0m 18s | hbase-compression-zstd in the patch passed. | |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 1m 11s | /results-checkstyle-root.txt | root: The patch generated 3 new + 164 unchanged - 2 fixed = 167 total (was 166) |
| +1 :green_heart: | xmllint | 0m 1s | No new issues. | |
| +1 :green_heart: | spotbugs | 11m 33s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 12m 13s | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | |
| +1 :green_heart: | spotless | 0m 47s | patch has no errors when running spotless:check. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 2m 27s | The patch does not generate ASF License warnings. | |
| 78m 50s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6932 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint |
| uname | Linux bfdf36491ca2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 20fc7b06a0fb3423f87b294666c79a07038fd65e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-diagnostics hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/4/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ master Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 12s | master passed | |
| +1 :green_heart: | compile | 5m 50s | master passed | |
| +1 :green_heart: | javadoc | 4m 18s | master passed | |
| +1 :green_heart: | shadedjars | 5m 56s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 3m 1s | the patch passed | |
| +1 :green_heart: | compile | 5m 45s | the patch passed | |
| +1 :green_heart: | javac | 0m 8s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | javac | 0m 20s | hbase-common generated 0 new + 3 unchanged - 9 fixed = 3 total (was 12) | |
| +1 :green_heart: | javac | 0m 20s | hbase-client in the patch passed. | |
| +1 :green_heart: | javac | 0m 14s | hbase-zookeeper generated 0 new + 3 unchanged - 2 fixed = 3 total (was 5) | |
| +1 :green_heart: | javac | 0m 13s | hbase-replication in the patch passed. | |
| +1 :green_heart: | javac | 0m 17s | hbase-http in the patch passed. | |
| +1 :green_heart: | javac | 0m 14s | hbase-procedure in the patch passed. | |
| +1 :green_heart: | javac | 0m 57s | hbase-server generated 0 new + 13 unchanged - 6 fixed = 13 total (was 19) | |
| +1 :green_heart: | javac | 0m 19s | hbase-mapreduce generated 0 new + 0 unchanged - 24 fixed = 0 total (was 24) | |
| +1 :green_heart: | javac | 0m 18s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | javac | 0m 25s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | javac | 0m 17s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | javac | 0m 18s | hbase-backup in the patch passed. | |
| +1 :green_heart: | javac | 0m 20s | hbase-it in the patch passed. | |
| +1 :green_heart: | javac | 0m 20s | hbase-rest in the patch passed. | |
| +1 :green_heart: | javac | 0m 18s | hbase-examples generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5) | |
| +1 :green_heart: | javac | 0m 13s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | javac | 0m 14s | hbase-compression-zstd in the patch passed. | |
| +1 :green_heart: | javadoc | 4m 16s | the patch passed | |
| +1 :green_heart: | shadedjars | 5m 50s | patch has no errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | unit | 0m 9s | hbase-checkstyle in the patch passed. | |
| +1 :green_heart: | unit | 2m 10s | hbase-common in the patch passed. | |
| +1 :green_heart: | unit | 1m 35s | hbase-client in the patch passed. | |
| +1 :green_heart: | unit | 0m 43s | hbase-zookeeper in the patch passed. | |
| +1 :green_heart: | unit | 0m 27s | hbase-replication in the patch passed. | |
| +1 :green_heart: | unit | 0m 50s | hbase-http in the patch passed. | |
| +1 :green_heart: | unit | 1m 30s | hbase-procedure in the patch passed. | |
| +1 :green_heart: | unit | 210m 44s | hbase-server in the patch passed. | |
| +1 :green_heart: | unit | 21m 30s | hbase-mapreduce in the patch passed. | |
| +1 :green_heart: | unit | 5m 32s | hbase-diagnostics in the patch passed. | |
| +1 :green_heart: | unit | 6m 59s | hbase-thrift in the patch passed. | |
| +1 :green_heart: | unit | 3m 48s | hbase-endpoint in the patch passed. | |
| +1 :green_heart: | unit | 16m 0s | hbase-backup in the patch passed. | |
| +1 :green_heart: | unit | 1m 15s | hbase-it in the patch passed. | |
| +1 :green_heart: | unit | 5m 8s | hbase-rest in the patch passed. | |
| +1 :green_heart: | unit | 2m 59s | hbase-examples in the patch passed. | |
| +1 :green_heart: | unit | 0m 58s | hbase-hbtop in the patch passed. | |
| +1 :green_heart: | unit | 6m 6s | hbase-compression-zstd in the patch passed. | |
| 336m 1s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6932 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 320fae4bc836 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 20fc7b06a0fb3423f87b294666c79a07038fd65e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/4/testReport/ |
| Max. process+thread count | 5396 (vs. ulimit of 30000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-diagnostics hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6932/4/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
Two general comments:
The description is too generic. SecurityManager is used in other places, mainly via HAdoop/UGI, which this patch does not fix. I suggest rewording it to reflect that this change is specific to the SecurityManager usage for tests with system.exit.
My other questions regarding JVM re-use in tests: Have you considered that the ExitHandler is JVM global ? Could that cause problems with test classes that may trigger exitHandler from multiple tests methods ? Could that be an issue when the JVM is re-used for the non-needsowncluster tests ?
Hadoop uses similar ExitHandler mechanism(s). We're doing something very similar (Replacing remaining SecurtityManager usages for system.exit) in Hadoop for 3.5.
But you're right in that Hadoop should expose this functionality in a standard manner so that we can set this in our tests for Hadoop jobs.
Unfortunately I'm not aware of a universal solution.