Istvan Toth

Results 504 comments of Istvan Toth

If there were no manual steps needed after spotless, then we can skip the final CI run. It is highly unlikely that any new change would cause problems for spotless....

please remove the colon from the commit message / PR description

I have not checked the tests thoroughly , but those failures look related.

Can you add a JIRA and a test case @potatochip ?

The PR that has added this patch seems to expect that transient is excluded by default, as it added transient to several members. TBH I'm not sure what we use...

> We do not want to serialize private fields? Really? I think most POJOs are private fields with getter and setter? The JSON serialization is used in a single test...

> The JSON serialization is used in a single test in debug log output. No it's not, we just got another ticket that demonstrates that it's also called by the...

Yes, using GSON to serializalize BucketCache is a clusterfuck. We need to check if if / how much if it the UI needs, and find some solution.

> I wonder if we should rather remove JSON deserialisation for BucketCache. Or at least put some safeguards that check for the size of the BucketCache object. Yes, it's completely...