Istvan Toth

Results 504 comments of Istvan Toth

> No it's not, we just got another ticket that demonstrates that it's also called by the UI from JSP. We're calling GsonUtil from rits.jsp , but luckily that's creating...

You're right, we're doing that. Thanks for catching @wchevreuil .

We've discussed this with @wchevreuil , the only sane ways seems to be removing any code that relies on serializing arbitrary multigigabyte internal objects (BucketCache) into JSON with reflection-happy Gson,...

Thank you. The thorny issue here backwards-forward compatibility. i.e. What happens if a client without this patch tries to run a scan on server with this change, and vice versa,...

Thanks. Can you please do a backport PR for branch-2 @chandrasekhar-188k ?

After commiting this (a little late), I realized that I have more questions: I see this annotation on ScannerModel: > @JsonInclude(JsonInclude.Include.NON_NULL) and > private boolean includeStartRow = true; > >...

Can you fix the test and answer my question question by mid next week @chandrasekhar-188k ? I don't want to start the winter holidays with the unfixed compatibility issue, so...

Thank you for the review, I have tried to address your comments. Shouldn't we use CAPS for the methodHandle constants ?