PHOENIX-7442 Apply Spotless to reformat the entire codebase

[NihalJain]

• Ran mvn spotless:apply to re-format the entire codebase
• No manual code change in this commit

[NihalJain]

Depends on https://github.com/apache/phoenix/pull/2023 Once that is merged we should rebase to master, re-run spotless and update code here.

[NihalJain]

Requires https://github.com/apache/phoenix/pull/2023. Hence in DRAFT!

[NihalJain]

TODO: Rebase before merge

[NihalJain]

Depends on #2023 Once that is merged we should rebase to master, re-run spotless and update code here.

TODO: Rebase before merge

Done.

CC: @stoty

[stoty]

Thank you. I suggest asking for reviews again on the last email thread. We want maximum visibility for this.

[NihalJain]

I suggest asking for reviews again on the last email thread. We want maximum visibility for this

Sure let me ping once again.

[lfrancke]

Thanks for this PR. I'm happy to spend some time reviewing it but I'm not sure where/how to start. I did look at 20 or so files and they look good. It's an honest question: Any suggestion how to really review this in a structured way? Or do you just look at a random subset of files and hope for the best.

[stoty]

Since this is an automated reformat, a complete a review is hopeless. It's more like:

• have all files been correctly reformatted ?
• Are there any generated files, which may conflict with spotless ?

Once we decided to reformat, and decided on the rules, review for the big bang reformat step is more of a formality.

[NihalJain]

Rebased with latest code!

[lfrancke]

So, I checked about 50 files at random and they all looked good to me. I also skimmed the entire list of 1500+ changed files and did not see anything that looks "wrong" (as in: generated files, binaries, build artifacts etc.).

I searched for antlr and a few other things, didn't see anything...

The only thing that I spotted (which is probably still irrelevant) are the test scenarios in phoenix-pherf where XML is changed slightly (but only whitespace) and I doubt that this is checked in the tests but I didn't run them.

From my amateur point of view this looks good! Thank you for keeping at it!

[virajjasani]

@NihalJain what is the diff b/ this PR and #2120?

[virajjasani]

@stoty before we merge this PR, i was just checking master builds and it seems hbase 2.6 profile builds/tests results are missing for the last ~5 builds. Any issues you might be aware of?

[stoty]

I was running tests for the 2.6.3 update, and it seems that Bson3IT is hanging with 2.6, @NihalJain . I haven't opened a ticket for that yet.

[NihalJain]

@NihalJain what is the diff b/ this PR and #2120?

#2120 which is nothing but #2024 and #2119 applied one after another. I had raised #2120 only to check if spotless check work after this patch is applied. May be we don't need it anymore as it anyways fails to apply patch. We can merge this one first and check if #2119 is not causing failure before we merge that. Basically #2119 enforces spotless on every build, this PR just reformats entire codebase.

Also I have run build and 'mvn clean verify' with this PR locally: there were 2 errors and 7 failures but not anything I think would be related to this change.

Also we need to rebase again once we are ready to merge, any commit to codebase causes conflict here as this patch touches almost all files.

[NihalJain]

Also I have run build and 'mvn clean verify' with this PR locally: there were 2 errors and 7 failures but not anything I think would be related to this change.

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ServerMetadataCacheIT.testSelectQueryFails:757 Query should have thrown Exception
[ERROR]   ServerMetadataCacheIT.testSelectQueryServerSideExceptionInValidation:670
Wanted but not invoked:
connectionQueryServicesTestImpl.refreshLiveRegionServers();
-> at org.apache.phoenix.cache.ServerMetadataCacheIT.testSelectQueryServerSideExceptionInValidation(ServerMetadataCacheIT.java:670)

However, there were exactly 80 interactions with this mock:
connectionQueryServicesTestImpl.connect(
    "jdbc:phoenix+zk:127.0.0.1\:61825::/hbase:client2;test=true;",
    {}
);
-> at org.apache.phoenix.cache.ServerMetadataCacheIT.testSelectQueryServerSideExceptionInValidation(ServerMetadataCacheIT.java:653)

connectionQueryServicesTestImpl.checkClosed();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.connect(ConnectionQueryServicesImpl.java:1233)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:306)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:308)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:310)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:312)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:317)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:320)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:322)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:324)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:326)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:327)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:329)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:331)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:334)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:337)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:339)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:354)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:356)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:359)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.getValidateLastDdlTimestampEnabled(ValidateLastDDLTimestampUtil.java:75)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.execute.MutationState.<init>(MutationState.java:262)

connectionQueryServicesTestImpl.addConnection(
    org.apache.phoenix.jdbc.PhoenixConnection@57a67298
);
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:364)

connectionQueryServicesTestImpl.isRenewingLeasesEnabled();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.addConnection(ConnectionQueryServicesImpl.java:6325)

connectionQueryServicesTestImpl.supportsFeature(
    RENEW_LEASE
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.isRenewingLeasesEnabled(ConnectionQueryServicesImpl.java:6667)

connectionQueryServicesTestImpl.getLowestClusterHBaseVersion();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$2.isSupported(ConnectionQueryServicesImpl.java:454)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.trace.util.Tracing.getConfiguredSampler(Tracing.java:127)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:373)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:375)

connectionQueryServicesTestImpl.getConnectionCount(
    false
);
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:388)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixConnection.<init>(PhoenixConnection.java:395)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixStatement.getDefaultQueryTimeoutMillis(PhoenixStatement.java:310)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.getValidateLastDdlTimestampEnabled(ValidateLastDDLTimestampUtil.java:75)

connectionQueryServicesTestImpl.isUpgradeRequired();
-> at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:356)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getTableRef(PhoenixConnection.java:705)

connectionQueryServicesTestImpl.getTable(
    null,
    [],
    [(byte) 0x4E, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x33, (byte) 0x34],
    9223372036854775807L,
    9223372036854775807L
);
-> at org.apache.phoenix.schema.MetaDataClient.updateCache(MetaDataClient.java:603)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.metaDataCoprocessorExec(ConnectionQueryServicesImpl.java:2375)

connectionQueryServicesTestImpl.getTable(
    [(byte) 0x53, (byte) 0x59, (byte) 0x53, (byte) 0x54, (byte) 0x45, (byte) 0x4D, (byte) 0x2E, (byte) 0x43, (byte) 0x41, (byte) 0x54, (byte) 0x41, (byte) 0x4C, (byte) 0x4F, (byte) 0x47]
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.metaDataCoprocessorExec(ConnectionQueryServicesImpl.java:2375)

connectionQueryServicesTestImpl.getController();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$8.call(ConnectionQueryServicesImpl.java:2658)

connectionQueryServicesTestImpl.getController(
    SYSTEM.CATALOG
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.getController(ConnectionQueryServicesImpl.java:2304)

connectionQueryServicesTestImpl.addTable(
    N000034,
    1752734591705L
);
-> at org.apache.phoenix.jdbc.PhoenixConnection.addTable(PhoenixConnection.java:1291)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.compile.QueryCompiler.<init>(QueryCompiler.java:182)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixStatement.getFetchSize(PhoenixStatement.java:2685)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.compile.StatementContext.<init>(StatementContext.java:161)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.compile.WhereOptimizer.pushKeyExpressionsToScan(WhereOptimizer.java:133)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.compile.QueryCompiler.compileSingleFlatQuery(QueryCompiler.java:828)

connectionQueryServicesTestImpl.getOptimizer();
-> at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:373)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getTableRef(PhoenixConnection.java:705)

connectionQueryServicesTestImpl.getAdmin();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.validateLastDDLTimestamp(ValidateLastDDLTimestampUtil.java:101)

connectionQueryServicesTestImpl.getLiveRegionServers();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.validateLastDDLTimestamp(ValidateLastDDLTimestampUtil.java:103)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:258)

connectionQueryServicesTestImpl.isRenewingLeasesEnabled();
-> at org.apache.phoenix.util.ScanUtil.isPacingScannersPossible(ScanUtil.java:1116)

connectionQueryServicesTestImpl.supportsFeature(
    RENEW_LEASE
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.isRenewingLeasesEnabled(ConnectionQueryServicesImpl.java:6667)

connectionQueryServicesTestImpl.getLowestClusterHBaseVersion();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$2.isSupported(ConnectionQueryServicesImpl.java:454)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.getValidateLastDdlTimestampEnabled(ValidateLastDDLTimestampUtil.java:75)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.execute.MutationState.<init>(MutationState.java:262)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.BaseResultIterators.initializeScan(BaseResultIterators.java:198)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.util.ScanUtil.getStatsForParallelizationProp(ScanUtil.java:1215)

connectionQueryServicesTestImpl.getTableStats(
    GuidePostsKey[physicalName=N000034,columnFamily=0]
);
-> at org.apache.phoenix.iterate.BaseResultIterators.getGuidePosts(BaseResultIterators.java:699)

connectionQueryServicesTestImpl.getTableRegions(
    [(byte) 0x4E, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x33, (byte) 0x34],
    [],
    [],
    300000
);
-> at org.apache.phoenix.iterate.DefaultParallelScanGrouper.getRegionBoundaries(DefaultParallelScanGrouper.java:81)

connectionQueryServicesTestImpl.getNextRegionStartKey(
    region=N000034,,1752734589503.ae8e18f78622858667aa13c774d33428., hostname=desktop-fkkbnr3.,34287,1752734467343, seqNum=2,
    [],
    null
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.getTableRegions(ConnectionQueryServicesImpl.java:1026)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.iterate.BaseResultIterators.explainUtil(BaseResultIterators.java:1814)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ExplainTable.getRegionLocationsForExplainPlan(ExplainTable.java:359)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.jdbc.PhoenixResultSet.<init>(PhoenixResultSet.java:165)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1458)

connectionQueryServicesTestImpl.getExecutor();
-> at org.apache.phoenix.iterate.ParallelIterators.submitWork(ParallelIterators.java:92)

connectionQueryServicesTestImpl.getRenewLeaseThresholdMilliSeconds();
-> at org.apache.phoenix.iterate.ParallelIterators.submitWork(ParallelIterators.java:115)

connectionQueryServicesTestImpl.getTable(
    [(byte) 0x4E, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x33, (byte) 0x34]
);
-> at org.apache.phoenix.execute.MutationState.getHTable(MutationState.java:410)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.iterate.TableResultIterator.<init>(TableResultIterator.java:161)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributesForPhoenixTTL(ScanUtil.java:1494)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributeForPaging(ScanUtil.java:1593)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributeForPaging(ScanUtil.java:1597)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributeForPaging(ScanUtil.java:1603)

connectionQueryServicesTestImpl.isRenewingLeasesEnabled();
-> at org.apache.phoenix.jdbc.PhoenixConnection.addIteratorForLeaseRenewal(PhoenixConnection.java:1412)

connectionQueryServicesTestImpl.supportsFeature(
    RENEW_LEASE
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.isRenewingLeasesEnabled(ConnectionQueryServicesImpl.java:6667)

connectionQueryServicesTestImpl.getLowestClusterHBaseVersion();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$2.isSupported(ConnectionQueryServicesImpl.java:454)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:102)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:106)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:108)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:112)


[ERROR]   ServerMetadataCacheIT.testSelectQueryWithOldDDLTimestampWithExceptionRetry:723
Wanted but not invoked:
connectionQueryServicesTestImpl.refreshLiveRegionServers();
-> at org.apache.phoenix.cache.ServerMetadataCacheIT.testSelectQueryWithOldDDLTimestampWithExceptionRetry(ServerMetadataCacheIT.java:723)

However, there were exactly 60 interactions with this mock:
connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixStatement.getDefaultQueryTimeoutMillis(PhoenixStatement.java:310)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.getValidateLastDdlTimestampEnabled(ValidateLastDDLTimestampUtil.java:75)

connectionQueryServicesTestImpl.isUpgradeRequired();
-> at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:356)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getTableRef(PhoenixConnection.java:705)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getMetaDataCache(PhoenixConnection.java:594)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.compile.QueryCompiler.<init>(QueryCompiler.java:182)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixStatement.getFetchSize(PhoenixStatement.java:2685)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.compile.StatementContext.<init>(StatementContext.java:161)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.compile.WhereOptimizer.pushKeyExpressionsToScan(WhereOptimizer.java:133)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.compile.QueryCompiler.compileSingleFlatQuery(QueryCompiler.java:828)

connectionQueryServicesTestImpl.getOptimizer();
-> at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:373)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getTableRef(PhoenixConnection.java:705)

connectionQueryServicesTestImpl.getAdmin();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.validateLastDDLTimestamp(ValidateLastDDLTimestampUtil.java:101)

connectionQueryServicesTestImpl.getLiveRegionServers();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.validateLastDDLTimestamp(ValidateLastDDLTimestampUtil.java:103)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getTableRef(PhoenixConnection.java:705)

connectionQueryServicesTestImpl.getTable(
    null,
    [],
    [(byte) 0x4E, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x34, (byte) 0x35],
    1752734616716L,
    9223372036854775807L
);
-> at org.apache.phoenix.schema.MetaDataClient.updateCache(MetaDataClient.java:603)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.metaDataCoprocessorExec(ConnectionQueryServicesImpl.java:2375)

connectionQueryServicesTestImpl.getTable(
    [(byte) 0x53, (byte) 0x59, (byte) 0x53, (byte) 0x54, (byte) 0x45, (byte) 0x4D, (byte) 0x2E, (byte) 0x43, (byte) 0x41, (byte) 0x54, (byte) 0x41, (byte) 0x4C, (byte) 0x4F, (byte) 0x47]
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.metaDataCoprocessorExec(ConnectionQueryServicesImpl.java:2375)

connectionQueryServicesTestImpl.getController();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$8.call(ConnectionQueryServicesImpl.java:2658)

connectionQueryServicesTestImpl.getController(
    SYSTEM.CATALOG
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.getController(ConnectionQueryServicesImpl.java:2304)

connectionQueryServicesTestImpl.addTable(
    N000045,
    1752734623436L
);
-> at org.apache.phoenix.jdbc.PhoenixConnection.addTable(PhoenixConnection.java:1291)

connectionQueryServicesTestImpl.isUpgradeRequired();
-> at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:356)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getTableRef(PhoenixConnection.java:705)

connectionQueryServicesTestImpl.getMetaDataCache();
-> at org.apache.phoenix.jdbc.PhoenixConnection.getMetaDataCache(PhoenixConnection.java:594)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.compile.QueryCompiler.<init>(QueryCompiler.java:182)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.jdbc.PhoenixStatement.getFetchSize(PhoenixStatement.java:2685)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.compile.StatementContext.<init>(StatementContext.java:161)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.compile.WhereOptimizer.pushKeyExpressionsToScan(WhereOptimizer.java:133)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.compile.QueryCompiler.compileSingleFlatQuery(QueryCompiler.java:828)

connectionQueryServicesTestImpl.getOptimizer();
-> at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:373)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:258)

connectionQueryServicesTestImpl.isRenewingLeasesEnabled();
-> at org.apache.phoenix.util.ScanUtil.isPacingScannersPossible(ScanUtil.java:1116)

connectionQueryServicesTestImpl.supportsFeature(
    RENEW_LEASE
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.isRenewingLeasesEnabled(ConnectionQueryServicesImpl.java:6667)

connectionQueryServicesTestImpl.getLowestClusterHBaseVersion();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$2.isSupported(ConnectionQueryServicesImpl.java:454)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ValidateLastDDLTimestampUtil.getValidateLastDdlTimestampEnabled(ValidateLastDDLTimestampUtil.java:75)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.execute.MutationState.<init>(MutationState.java:262)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.BaseResultIterators.initializeScan(BaseResultIterators.java:198)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.util.ScanUtil.getStatsForParallelizationProp(ScanUtil.java:1215)

connectionQueryServicesTestImpl.getTableStats(
    GuidePostsKey[physicalName=N000045,columnFamily=0]
);
-> at org.apache.phoenix.iterate.BaseResultIterators.getGuidePosts(BaseResultIterators.java:699)

connectionQueryServicesTestImpl.getTableRegions(
    [(byte) 0x4E, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x34, (byte) 0x35],
    [],
    [],
    300000
);
-> at org.apache.phoenix.iterate.DefaultParallelScanGrouper.getRegionBoundaries(DefaultParallelScanGrouper.java:81)

connectionQueryServicesTestImpl.getNextRegionStartKey(
    region=N000045,,1752734614581.1c159a1e09687f22a5a55b3151f117a1., hostname=desktop-fkkbnr3.,34287,1752734467343, seqNum=2,
    [],
    null
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.getTableRegions(ConnectionQueryServicesImpl.java:1026)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.iterate.BaseResultIterators.explainUtil(BaseResultIterators.java:1814)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ExplainTable.getRegionLocationsForExplainPlan(ExplainTable.java:359)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.jdbc.PhoenixResultSet.<init>(PhoenixResultSet.java:165)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1458)

connectionQueryServicesTestImpl.getExecutor();
-> at org.apache.phoenix.iterate.ParallelIterators.submitWork(ParallelIterators.java:92)

connectionQueryServicesTestImpl.getRenewLeaseThresholdMilliSeconds();
-> at org.apache.phoenix.iterate.ParallelIterators.submitWork(ParallelIterators.java:115)

connectionQueryServicesTestImpl.getTable(
    [(byte) 0x4E, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x30, (byte) 0x34, (byte) 0x35]
);
-> at org.apache.phoenix.execute.MutationState.getHTable(MutationState.java:410)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.iterate.TableResultIterator.<init>(TableResultIterator.java:161)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributesForPhoenixTTL(ScanUtil.java:1494)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributeForPaging(ScanUtil.java:1593)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributeForPaging(ScanUtil.java:1597)

connectionQueryServicesTestImpl.getProps();
-> at org.apache.phoenix.util.ScanUtil.setScanAttributeForPaging(ScanUtil.java:1603)

connectionQueryServicesTestImpl.isRenewingLeasesEnabled();
-> at org.apache.phoenix.jdbc.PhoenixConnection.addIteratorForLeaseRenewal(PhoenixConnection.java:1412)

connectionQueryServicesTestImpl.supportsFeature(
    RENEW_LEASE
);
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl.isRenewingLeasesEnabled(ConnectionQueryServicesImpl.java:6667)

connectionQueryServicesTestImpl.getLowestClusterHBaseVersion();
-> at org.apache.phoenix.query.ConnectionQueryServicesImpl$2.isSupported(ConnectionQueryServicesImpl.java:454)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:102)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:106)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:108)

connectionQueryServicesTestImpl.getConfiguration();
-> at org.apache.phoenix.iterate.ScanningResultIterator.<init>(ScanningResultIterator.java:112)


[ERROR]   HAConnectionWithMasterAndRPCRegistryIT.testAllWrappedConnectionsNotClosedAfterStandbyURLChange:425
[ERROR]   HAConnectionWithMasterAndRPCRegistryIT.testConnectionWhenActiveHBaseRestarts:256 expected:<jdbc:phoenix+master:[DESKTOP-FKKBNR]3\:38085:::USER_FOO> but was:<jdbc:phoenix+master:[desktop-fkkbnr]3\:38085:::USER_FOO>
[ERROR]   HAConnectionWithMasterAndRPCRegistryIT.testFailoverCanFinishWhenOneConnectionGotStuckClosing:166 expected:<jdbc:phoenix+master:[DESKTOP-FKKBNR]3\:36583:::USER_FOO> but was:<jdbc:phoenix+master:[desktop-fkkbnr]3\:36583:::USER_FOO>
[ERROR]   MaxConcurrentConnectionsIT.testDeleteRuntimeFailureClosesConnections:132 Found 1 connections still open. expected:<0> but was:<1>
[ERROR] Errors:
[ERROR]   CDCQueryIT.testSelectGeneric:512->checkIndexPartitionIdCount:189 ArrayIndexOutOfBounds 3
[ERROR]   ConcurrentGetTablesIT.testConcurrentGetTablesWithQueries:143 » TestTimedOut test timed out after 300000 milliseconds
[INFO]
[ERROR] Tests run: 3430, Failures: 7, Errors: 2, Skipped: 111

[virajjasani]

[ERROR] HAConnectionWithMasterAndRPCRegistryIT.testAllWrappedConnectionsNotClosedAfterStandbyURLChange:425 [ERROR] HAConnectionWithMasterAndRPCRegistryIT.testConnectionWhenActiveHBaseRestarts:256 expected:jdbc:phoenix+master:[DESKTOP-FKKBNR]3\:38085:::USER_FOO but was:jdbc:phoenix+master:[desktop-fkkbnr]3\:38085:::USER_FOO [ERROR] HAConnectionWithMasterAndRPCRegistryIT.testFailoverCanFinishWhenOneConnectionGotStuckClosing:166 expected:jdbc:phoenix+master:[DESKTOP-FKKBNR]3\:36583:::USER_FOO but was:jdbc:phoenix+master:[desktop-fkkbnr]3\:36583:::USER_FOO [ERROR] MaxConcurrentConnectionsIT.testDeleteRuntimeFailureClosesConnections:132 Found 1 connections still open. expected:<0> but was:<1> [ERROR] Errors: [ERROR] CDCQueryIT.testSelectGeneric:512->checkIndexPartitionIdCount:189 ArrayIndexOutOfBounds 3 [ERROR] ConcurrentGetTablesIT.testConcurrentGetTablesWithQueries:143 » TestTimedOut test timed out after 300000 milliseconds [INFO] [ERROR] Tests run: 3430, Failures: 7, Errors: 2, Skipped: 111

This seem good. If you run these failed tests individually, they should pass hopefully.

[virajjasani]

I was running tests for the 2.6.3 update, and it seems that Bson3IT is hanging with 2.6, @NihalJain . I haven't opened a ticket for that yet.

Let me take a look, this might have been caused by me.

Also we need to rebase again once we are ready to merge, any commit to codebase causes conflict here as this patch touches almost all files.

Yes, painful indeed. How about we target merging this PR on Mon morning (IST/CET)?

[stoty]

I was running tests for the 2.6.3 update, and it seems that Bson3IT is hanging with 2.6, @NihalJain . I haven't opened a ticket for that yet.

Let me take a look, this might have been caused by me.

Thanks. https://issues.apache.org/jira/browse/PHOENIX-7674 is the ticket

Also we need to rebase again once we are ready to merge, any commit to codebase causes conflict here as this patch touches almost all files.

Yes, painful indeed. How about we target merging this PR on Mon morning (IST/CET)?

Fine by me.

[NihalJain]

Yes, painful indeed. How about we target merging this PR on Mon morning (IST/CET)?

Sounds good to me. I will rebase again and keep this ready by Sunday midnight IST.

[virajjasani]

Or, if you both are fine and willing to merge sometime today after latest rebase, that's fine too. I think it's almost clear that this should not cause any regression. Reg Bson3IT, let me take a look, the fix can come after the spotless merge also, it's fine either way.

[NihalJain]

Or, if you both are fine and willing to merge sometime today after latest rebase, that's fine too. I think it's almost clear that this should not cause any regression. Reg Bson3IT, let me take a look, the fix can come after the spotless merge also, it's fine either way.

Fine with me as this PR does not enforce 'spotless:check' on builds. I can rebase again right away!

[stoty]

If there were no manual steps needed after spotless, then we can skip the final CI run. It is highly unlikely that any new change would cause problems for spotless.

We don't need to wait for the BSon3IT fix with the big patch.

On Fri, Jul 18, 2025 at 6:48 AM Nihal Jain @.***> wrote:

NihalJain left a comment (apache/phoenix#2024) https://github.com/apache/phoenix/pull/2024#issuecomment-3086728319

Yes, painful indeed. How about we target merging this PR on Mon morning (IST/CET)?

Sounds good to me. I will rebase again and keep this ready by Sunday midnight IST.

— Reply to this email directly, view it on GitHub https://github.com/apache/phoenix/pull/2024#issuecomment-3086728319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKM5LWQKPURBRRLAUBWE33JB4BDAVCNFSM6AAAAABRJJSHN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBWG4ZDQMZRHE . You are receiving this because you were mentioned.Message ID: @.***>

-- István Tóth | Sr. Staff Software Engineer Email: @.*** cloudera.com https://www.cloudera.com [image: Cloudera] https://www.cloudera.com/ [image: Cloudera on Twitter] https://twitter.com/cloudera [image: Cloudera on Facebook] https://www.facebook.com/cloudera [image: Cloudera on LinkedIn] https://www.linkedin.com/company/cloudera

---

[virajjasani]

Sounds good, please feel free to merge anytime. Once rebased and merged, we should trigger build for PR https://github.com/apache/phoenix/pull/2119 and soon merge that also.

[NihalJain]

PR is rebased with latest master!

[NihalJain]

PR is rebased with latest master!

Ah I see another commit by Viraj, may be not a problem. Let me double check anc rebase again!

[virajjasani]

2 lines added :)

[NihalJain]

2 lines added :)

Ah yes, we are good, I have rebased on top of that and reran 'mvn spotless:check' no issues! 🚀

[virajjasani]

btw why IT test classes are not updated by the plugin?

[NihalJain]

IT test classes

Oh is it any sample file names, I can look into that

[virajjasani]

All tests under https://github.com/apache/phoenix/tree/master/phoenix-core/src/it/java/org/apache