Istvan Toth

Results 504 comments of Istvan Toth

If we keep Woodstock and dependency manage it to a non-vulnerable version then we can be sure that we won't break anything, and the scanners will be happy. We already...

> The challenge with the current approach is that someone would need to update this whenever the hadoop is updated. I hope it is not going to downgrade the transitive...

Please do not use colons in the commit message.

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2119/1/console in case of problems.

We should make sure to merge the reformat and this one together.

Maybe make PR with both in a commit chain ?

I agree, separate commits, but we should make sure that nothing gets committed without spotless between the reformat and enabling spotless from CI.