Christophe Coevoet comments

Results 2811 comments of


                                            Christophe Coevoet

[4.x] Remove support for "automagically" guessing extension class names from short names

to me, this depends of the target you have for 4.0. If the goal is to have a small 4.0 release soon to allow supporting Symfony 8, this should not...

Use `IsCsrfTokenValid` Attribute

There is a discussion about it in https://github.com/symfony/symfony/issues/57343

composer not open folder

Why wanting to open it ? a Phar file is not a folder.

Implement Collator::compare

Contributions are welcome to expend the polyfilled API surface

Add ext-intl requirement to composer.json

PRs must indeed be sent o the main repo.

Add polyfill for grapheme_levenshtein

sure. Contributions are welcome.

False-positive `UnusedFunctionCall` on `curl_share_setopt()`

The solution is probably to add `curl_share_setopt` in the list of [impure functions](https://github.com/vimeo/psalm/blob/6.x/dictionaries/ImpureFunctionsList.php) (as done already for `curl_setopt`)

[Intl] Add PHP 8.5 `IntlListFormatter` to ICU polyfill

This should be added in symfony/polyfill-intl-icu (with the other formatters) instead of being a new package IMO > It only supports `en` locale. However, PHP applications that require this package...

[Intl] Add PHP 8.5 `IntlListFormatter` to ICU polyfill

@Ayesh do you plan to finish this PR (by taking review comments into account) ?

Type error only occurring locally when analysing entire codebase

For reference, this is solved when using Psalm 6.13.1