Christophe Coevoet

Results 2813 comments of Christophe Coevoet

Doing the same with a mandatory `type` key for the scenario shape works fine: https://phpstan.org/r/0db4aace-e150-4eb3-9392-f67deb44cc42 However, I'm trying to add type for an existing array structure being processed, so this...

Btw the tips being reported are quite confusing. It reports 2 tips about type mismatches inside the `steps` offset (for the union of the `TArgumentHash` type). But `TScenarioHash` and `TOutlineHash`...

Here is a reduced version: https://phpstan.org/r/923d55d8-296e-42ea-897b-0dffb23e4ef5 The original one might still be useful to investigate the issue with the computation of tips (the weird ones are gone from my reduced...

There is already a `--fail-on-empty-test-suite` config setting (the XML config file also supports it). Isn't it solving that need already ?

@staabm just set `failOnEmptyTestSuite="true"` in your XML config file (or `failOnAllIssues="true"`). Right now, none of the `failOn*` setting defaults to true, so this is consistent.

your suggested change for MemcacheStore still assumes that the lock store is the only consumer of the whole Memcache instance (so that clearing the memcache instance does not remove other...

I suggest implementing IntlListFormatter only for `en`, like all our other formatters in `symfony/polyfill-intl-icu`. Projects wanting to support all locales will need to install ext-intl to have access to the...

Given that those events bubble, there is no point defining them only as override of `addEventListener` in each specific element. This would not provide type safety for delegated listeners. Instead,...

I found some usages in https://symfony.com/doc/current/service_container.html#multiple-service-definitions-using-the-same-namespace the PHP snippet should probably be updated to use the PHP DSL (also used in the previous snippet) instead of the lower-level loader API.

https://github.com/cucumber/tag-expressions/ does not provide a PHP parser yet, but I suggest contributing it upstream if accepted instead of implementing it in Behat.