Christophe Coevoet

Results 2811 comments of Christophe Coevoet

I think the best solution here would be to cache the unpatched file, as the goal of the cache is to cache the network activity. Most services don't have any...

Note that this also applies to union shapes (see #1900)

@jderusse the JS SDK you linked is the old one. And `match` in PHP requires exhaustiveness, which is impacted by this. Also, the suggestion done in `#1923` basically uses `string`...

Note that this means we will never be able to use PHP enums then.

Indeed, their JS SDK is inconsistent: - for string-based enums, the deserialization only expects a string without extra validation, meaning that they return unknown values directly (breaking their type declaration):...

For this time, merging https://github.com/Async-AWS-PR/commits-since-release-counter/pull/7 (which is necessary as `ubuntu-20.04` has been shutdown) would be enough to add back some activity on the repo.

An upload with a POST policy is not relying on a presigned request. It relies on a different feature (which exists *only* for S3, and only for uploading a file)....

Looks like the CodeGenerator has an inconsistency in its handling of objects without properties. However, having such object in the response does not make sense to me. Either the API...

The shape description uses `document: true` in https://github.com/aws/aws-sdk-php/blob/33f6d393834053b11a5fc10573a211d92e61c2db/src/data/bedrock-runtime/2023-09-30/api-2.json#L970-L974 this is probably not handled by the code generator

I discovered that `DocumentSource` uses `union: true` as well: https://github.com/aws/aws-sdk-php/blob/33f6d393834053b11a5fc10573a211d92e61c2db/src/data/bedrock-runtime/2023-09-30/api-2.json#L1013-L1021 This also seems something new in those API declarations.