Christophe Coevoet

Results 2813 comments of Christophe Coevoet

Whitespace control happens at the lexer level. Having a tag affecting the way the lexer operate is quite hard as this cannot be implemented using the tag parsing system. Auto-escaping...

The lexer being lossy is not an issue for Twig at all. Being able to recreate the original code from the tokens is **not** something Twig needs. And we cannot...

> although that package is deprecated Where did you see that this package is deprecated ?

@ericmorand see my comment on the PR: https://github.com/twigphp/Twig/pull/4703#issuecomment-3442743918 The extension can run with either `ext-intl` or `symfony/polyfill-intl-icu`, not just with `ext-intl`. and `symfony/polyfill-intl-icu` cannot declare it provides `ext-intl` (unlike some...

> I'm not sure I understand you/polyfills correctly, but for the polyfill to be useful, wouldn't it need to be downloaded together with the extension as well (so, a dependency...

this change is legitimate. None of the static analysis tools treat `bool[]` as meaning a list.

This should be implemented as a separate executable than composer (btw, `npx` is separate from `npm for the same reason: you cannot support `composer package/name` as that conflicts with composer...

@imliam implementing this by parsing command names into package names when they contain a `/` would be an implementation nightmare IMO due to the way `symfony/console` works, and it also...

How does `BCMath\Number` behaves regarding the change tracking in the ORM ? The discussion in DBAL says it should be compared with `==`, and I don't think this is what...

Doing BC breaks just for the sake of it is not a good idea. Any BC break has a migration cost for the ecosystem.