Christophe Coevoet

Results 2812 comments of Christophe Coevoet

And if phpstan does not want to support `@phpstan-sealed` on concrete classes (which would be a shame IMO, as it would make sealing less powerful than in any other language...

> ndeed looking the description of this interface https://github.com/phpstan/phpstan-src/blob/ae9d277460e1d27815df139c2b93dbfbcc62e84e/src/Reflection/AllowedSubTypesClassReflectionExtension.php#L8-L10 "extend a certain parent class" does not imply that it is meant to be used only on abstract classes. But indeed,...

> PHPStan could be made to do it itself but right now this is a viable workaround would you accept a PR doing that in phpstan directly (as was done...

If you don't close the connection between requests, that's quite expected actually. right now, DoctrineBundle has special logic to clear entity managers and close connections on `shutdown`, which was added...

What is your use case for replacing the ConnectionFactory ?

well, then, we are probably missing a bunch of silencing.

@carsonbot this is not resolved. Our testsuite still leaks the warning output instead of capturing it.

The conversion of markdown to HTML is not performed by Twig itself. The MarkdownExtension relies on an external markdown engine (see the MarkdownInterface and its different implementations for the supported...

Twig does not have a concept of statement. It has a concept of tags, where each tag parser is mostly free to parse things in any way it wants. So...

@rgpublic but this works only if tag parsers don't treat `;` as meaning something in their own scope (which they could totally do today)