Stéphane Raimbault comments

Results 123 comments of


                                            Stéphane Raimbault

New function modbus_reply_callback()

Thank you for your patch and the very good documentation. The patch duplicates too many lines of code. I think we can achieve the same behaviour with https://github.com/stephane/libmodbus/pull/323. It would...

HAVE_NETINET_IN_H as guard around header

Thank you @diplfranzhoepfinger (no need for CLA for such small changes).

incorrect type to store socket on Windows

Do you mean `int` are not set according to the underlying architecture on Windows (64 bits)?!

modbus_receive() function returns -1 on USB serial port (TTL level) devices

The provided information aren't helpful to help you.

Buffer overflow after several repeated connections between master and slave using the tcp protocol.

Thank you @psychon for cathing the missing `modbus_close(ctx)` in @GodLiu1 application.

Document macros for error codes corresponding to Modbus exceptions

Thank you.

Django OperationalError: the connection is closed

The release 2.13.0 (until 2.13.2) doesn't work anymore with the new connection pool of Django 5.1. My test suite passes with 2.12.0. ```python connection = self.pool.getconn() ``` raises a PoolTimeout.

Connection timeout caused by delay after write operation in rtu_send

@habu1010 you're right, my bad. If we remove this discutable computation, do you think we should add set/get methods to define the RTS delay (the delay before and after transmission)?

Connection timeout caused by delay after write operation in rtu_send

Please provide me more information about the RTS needs. Do we need a different delays before and after the write? Etc.

Update unit-test.h.in

It seems a wrong error (const + const = const) from your compiler. How did your trigger the issue?