Stéphane Raimbault comments

Results 123 comments of


                                            Stéphane Raimbault

Simple code compilation problem - linker error LNK2019 - only with RTU

I can't help you with Visual Studio issue, may be someone will be able...

modbus_set_slave() disallows Slave IDs above 247

I think I'll increase standard conformance (for modbus_reply for example) and offer a new setting to disable it!

modbus_set_slave() disallows Slave IDs above 247

Nope, not yet.

modbus_set_slave() disallows Slave IDs above 247

https://github.com/stephane/libmodbus/tree/compliance

modbus_set_slave() disallows Slave IDs above 247

Quirks or compliance. Opinion asked on mailing list.

modbus_set_slave() disallows Slave IDs above 247

I intend to relax the rules by default and to offer a strict mode.

modbus_set_slave() disallows Slave IDs above 247

I think it's time to resolve this issue! @mhei started a branch to set the various quirks (https://github.com/mhei/libmodbus/commits/quirks). I did something similar in https://github.com/stephane/libmodbus/tree/compliance and today in https://github.com/stephane/libmodbus/tree/is_compliant I need...

modbus_new_tcp_pi allocates way more memory than modbus_new_tcp and has arbitrary length limits on its string arguments

LGTM. Could you provide a PR, please?

Unify file registers

Very nice contribution but I need a CLA from original author to merge it...

Issues with initializing the registers in the server

What value do you use for `start_registers`? How many registers did you allocate?