libmodbus icon indicating copy to clipboard operation
libmodbus copied to clipboard

HAVE_NETINET_IN_H as guard around header

Open diplfranzhoepfinger opened this issue 1 year ago • 3 comments

Hi,

it does not make sense to have this in a config.h, and then still include it when HAVE_NETINET_IN_H is 0.

This fix solves this.

diplfranzhoepfinger avatar Aug 17 '24 18:08 diplfranzhoepfinger

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Aug 17 '24 18:08 cla-bot[bot]

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

cla-bot[bot] avatar Aug 18 '24 18:08 cla-bot[bot]

Yes, the changes make sense. But I'd prefer to have them all in a single commit. And please use a more verbose description instead of just "update ...". You can re-use the wording of the PR itself for example.

DONE

diplfranzhoepfinger avatar Aug 18 '24 18:08 diplfranzhoepfinger

Thank you @diplfranzhoepfinger (no need for CLA for such small changes).

stephane avatar Oct 21 '24 17:10 stephane