Stéphane Raimbault comments

Results 123 comments of


                                            Stéphane Raimbault

Entry in INSTALLED_APPS but not in SHARED_APPS or TENANT_APPS can't migrate

The installation could recommend to use: `INSTALLED_APPS = list(SHARED_APPS) + [app for app in TENANT_APPS if app not in SHARED_APPS]` Extracted from http://mycodesmells.com/post/django-tutorial-multi-tenant-setup

Added Hardware Up and Down RTS Setting for RS485.

This part was already complex but with the splitting between software and hardware, it's even more complex but I think you need it so it makes sense to add this...

Fixed MODBUS_ERROR_RECOVERY_LINK not working on Windows.

Added to CLA bot.

Added a client context parameter to the modbus_t context, and getter/setter methods.

I'm reluctant to add any new field to _modbus struct (even more a free pointer not managed). Could you explain your use case?

Add Android build scripts, #2

Could you ensure these build scripts are up to date and comment the way to build for Android in the README file, please?

Proxy - modbus_proxy function

Does it still issues on this proxy code?

Proxy - modbus_proxy function

The PR hasn't be updated to handle non standard modbus frames and I can't read the code sample from @hanusek (#include lines are empty). Unit tests and documentation are missing...

Proxy - modbus_proxy function

Anyone interested to update this PR?

Introduce support for callback functions

Hi Michael, I intend to add a callback support to libmodbus for years! I'll try to give feedback on your RFC in following weeks

feat(modbus): use poll() for Linux instead of select()

After a quick look, it seems the tv struct could be replaced by a single integer var (ms). Are you sure it's supported on other Unix systems (FreeBSD, MacOS, etc)?