Stéphane Raimbault comments

Results 123 comments of


                                            Stéphane Raimbault

Fixes float encoding/decoding for both big and little endian (fixes #665).

Don't know how to reopen this PR...

Fixes float encoding/decoding for both big and little endian (fixes #665).

BTW I'm sure the mask and shift approach w/o memcpy or useless bswap of your PR is the right way.

warning: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Wimplicit-function-declaration]

No I mean accept4.

modbus_rtu_set_serial_mode cannot be called before modbus_connect

I think it's clearer in latest documentation (around 2 years), could you create a PR with the documentation parts to improve?

configure.js generate version not correct

I don't have a win32 installation ready, in the meantime could you test https://github.com/stephane/libmodbus/commit/225fbbb175d3e795b6eacf12ab2a1705f3ea47e1 ?

Setting transaction id in modbus_send_raw_request

This one and others, I should have more time starting next week.

Setting transaction id in modbus_send_raw_request

Next week -> Next year 😬. Very good PR, thank you @cedricboudinet

TCP backend should handle out of order responses

Not triaged yet but it seems it could be interesting to add in a major release (3.4 or 4.0 material)

[Project] CLA processing is laggy (want to upstream support for Modbus over USB)

I've just uploaded all the signed CLA to the bot.

TCP RTU gateway support

Could you add missing tests, please? Documentation will be great too ;)