Markus Staab

Results 959 comments of Markus Staab

see how frequent these top-10 functions are called ![grafik](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/assets/120441/53427803-e9e7-49c8-90ca-f52a42e29172) at such an high rate the blackfire profiler cannot do a good job anymore.

I would look into the `Token.php` class only, which seem to be a high roller as per screen above

just re-phrased the use-case and the PR description. I think the change itself is still valuable

I have no experience with other profilers then xdebug and blackfire

No worries. It was no substantial improvement so fine to focus on other stuff

> What about allowing a negative number in `maximumNumberOfProcesses` that would mean the same thing? tbh. I though about the same thing when reading the blog post (before the blog...

alle static methods of the DB Abstract method should be made non-static and therefore all the subclasses need to be adjusted accordingly.

would end-to-end tests be sufficient to get this moving forward or do we also need unit tests for the caching related stuff?

> today I was looking into why the unit test-suite requires [3-4GB of RAM on my windows machine](https://github.com/sebastianbergmann/phpunit/issues/5758#issuecomment-2024855689). I think the initial problem I found will be fixed with https://github.com/sebastianbergmann/phpunit/pull/5774...

ist das thema noch offen oder bereits durch die gemergten PRs erledigt?