Markus Staab
Markus Staab
I don't say its wrong to use headers_sent() in tests, but the original example does not contain any code which sends headers, therefore I don't see why it should be...
> For this the reproducible example should be sufficient. no its not. the results for the given example look correct to me for PHPUnit 10+. its fine that PHPUnit 10.x...
since no test is failling after the change it seems we are missing a NodeScopeResolverTest with a type inference assertion for this variable :)
@mvorisek will continue after vacation. Please make sure to sponsor my efforts. Thanks in advance
@VincentLanglet I can't remember. feel free to continue it
(submitted, so we can discuss the 2 different approaches)
> * currently there is no ThrowTypeExtension I have patch prepared, which will be submitted after other currently open PRs are merged
unrelated CI error will be fixed in https://github.com/phpstan/phpstan-src/pull/3424
@Wirone here we have the tests. running the tests, doesn't work atm though, because PHPStan is installed with a different composer.json then PHPUnit. I think we would need a phpunit...
> Side question: would it be possible to make PHPStan aware of named capturing groups? these are already supported. I need to look into why this particulare case doesn't work