Markus Staab comments

Results 1491 comments of


                                            Markus Staab

Narrowing down of an instance class in `else` branch doesn't work

It should work for final classes though https://psalm.dev/r/85e60a375e

Add test for #1000

thank you. could you double check whether this test fails with a sabre/dav version from sept 2017?

Could you provide a reproducible reduced testcase which shows the problem? Additonally, could you provide a performance profile (e.g. With blackfire) which shows a calender-query request you are talking about?

calendarQuery is inefficient

Having a benchmark just makes sure we can optimize your real use-case. Also having a blackfire profile will show room for improvements

calendarQuery is inefficient

Did you measure the calendar-query on your end? How slow is it actually?

calendarQuery is inefficient

It would be great to see a blackfire profile of your 7 second taking request

RoundFunctionReturnTypeExtension supports types with ConstantScalar

which problem does this change solve? whats your real world use-case?

Enhancement: Increase `phpstan/phpstan` level from `5` to `6`

huhu, just to let you know: it seems the rector team is currently working on a tool to add such types. see - https://x.com/rectorphp/status/1915814878679310735 - https://x.com/rectorphp/status/1916060878081761365 - https://x.com/rectorphp/status/1916060878081761365 might be...

Change return type of apcu_inc & apcu_dec function

it looks good to me. ondrej is currently focused on php 8.5 support. just leave this here as is for now. I think he will come back to it when...

Fix get_object_vars() return type

Please add a test in the tests/PHPStan/Analyser/nsrt directory asserting the type of the example of your issue. For inspiration see other files in this folder. Just adding a new file...