Markus Staab comments

Results 1072 comments of


                                            Markus Staab

trafficstars

assertStringStartsWith after assertNotEmpty fails

I was not able to reproduce the issue, but I think https://github.com/phpstan/phpstan-src/pull/4473 will have fixed it in case its still relevant

assertStringStartsWith after assertNotEmpty fails

@gisostallenberg please double check whether this issue still reproduces on the latest release

Is this package still actively maintained?

we have new maintainers for this package

Is this package still actively maintained?

we discuss a new release here: https://github.com/thecodingmachine/safe/issues/499

Ignore output colors when TERM is dumb

btw: there is a "standard", see https://no-color.org/

Multi-line strings not supported for assert_equals

I wonder whether this problem is related to IFS: https://unix.stackexchange.com/questions/184863/what-is-the-meaning-of-ifs-n-in-bash-scripting ?

Display total number tests

Calculating assertions count for a test with dataprovider(s) is not possible/easy, I guess?

`ParameterBag->keys()` return type is incorrect

//cc @stof as you added the more precise type with https://github.com/phpstan/phpstan-symfony/commit/b055cab8b0dc01fb462220e3796ace29d9dab27d back then. wdyt?

`ParameterBag->keys()` return type is incorrect

> a case where using strict_types in PHP is actually breaking things could you give a 3v4l.org example of what you mean?

Resolve substr based on configured PHP version

btw: since phpunit got upgraded on the PHPStan 2.x branch, we need to be careful to send PRs to PHPStan 1.12.x only when easy mergabe into 2.x (attributes got added...