Markus Staab comments

Results 1213 comments of


                                            Markus Staab

Generated baseline can't be used if regex can't be compilated to UTF-8 chars

I just found https://github.com/nette/neon/issues/72 in which there was a similar discussion with other control characters. will investigate. opened a new upstream issue in https://github.com/nette/neon/issues/76

Add fetchJobs option to parallelize submodule updates

I am not someone who can push this PR either.

Disable result set type-inference and other rules

Hi. Could you create a reproducer for the crash? Which php version, which dbal driver?

Disable result set type-inference and other rules

I guess you could make your case easier to reproduce when invoking PHPStan with `-v --debug`. I think when we disable all features but syntax checking it will not stop...

Disable result set type-inference and other rules

looking more closely at the stacktrace of your error it seems you are using `ReplayAndRecordingQueryReflector` in combination with `SchemaHasherMysql`. you could just use `MysqliQueryReflector` without wrapping it into `ReplayAndRecordingQueryReflector` -...

Improve `ReflectionEnum->getCases()` performance

> FWIW, `array_map()` is less magic than loops in general I feel `array_map` makes me read code backwards. I really like the simplicity of `foreach`. maybe I suck in reading...

Improve `ReflectionEnum->getCases()` performance

> I'd rather memoize `cases` instead, in future. done

Improve `ReflectionEnum->getCases()` performance

please advice on how to make psalm happy or how/where to move this thing ;)

Improve `ReflectionEnum->getCases()` performance

I am fine with closing it

Bring Mutation Test score back to 100%

> we could also contribute upstream types, maybe 🤔 I think this is what I did with https://github.com/nikic/PHP-Parser/pull/985