opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard
verified publisher icon commaai

Make can_valid consider checksums and counters

Open sshane opened this issue 3 years ago • 0 comments

In this segment (6f63165f17c0e270|2022-03-19--23-09-55--92), a Genesis had a controls mismatch due to the car sending a message with an invalid checksum so panda stopped allowing messages but we don't check this in the CAN parser.

  • [ ] Consider checksums and counters (need flags to ignore checksums in certain cases? eg. legacy HKG)
  • [ ] Add checksum for Hyundai

sshane avatar Apr 21 '22 00:04 sshane