Sabet Seraj

turbKSP crashes for certain flow conditions

1

## Description Using turbKSP (`"ANKUseTurbDADI": False`) can cause optimizations to crash seemingly randomly with the following error: ``` [106]PETSC ERROR: --------------------- Error Message -------------------------------------------------------------- [106]PETSC ERROR: Argument out of range...

Complex instance will not run when a real instance exists

1

## Description Complex ADflow will not run properly when a real instance exists at the same time. ### Steps to reproduce issue Here is a MWE: ``` from baseclasses import...

## Description The matrix-based derivative routines do not fully account for overset connectivities. This results in inaccurate gradients if using the matrix-based adjoint with overset meshes. This also affects the...

## Description There are two problems with the SA-R implementation [here](https://github.com/mdolab/adflow/blob/e091afce4766eaf9a6b7061fda33369ed09f6629/src/turbulence/sa.F90#L269-L273) (the same code also appears in the blockette code) when compared to the [TMR website](https://turbmodels.larc.nasa.gov/spalart.html#saR): 1) The min function...

## Description Running Valgrind on MACH-Aero optimization scripts results in numerous errors from ADflow and IDWarp, such as: `Conditional jump or move depends on uninitialised value(s)` and `Use of uninitialised...

## Description We should remove the `-ffast-math` flag from the default gfortran config and retrain all the tests without this flag. Users can still choose to add this flag and...

fprettify

6

## Purpose Formatting the Fortran code with fprettify ## Expected time until merged 1 week ## Type of change - [ ] Bugfix (non-breaking change which fixes an issue) -...

Time spectral stability derivatives are broken

2

## Description As mentioned in the [code](https://github.com/mdolab/adflow/blob/476a98e7dab59177bf51b29337cd5521fdcd0ae1/src/solver/surfaceIntegrations.F90#L324-L327C17), the time spectral stability derivatives are broken. I am creating this issue for greater visibility.

## Description The following files related to dynamic stability are outdated and do not work: - pyDynamicPerformance.py - pyPerformanceClass.py - pyWeightAndBalance.py - pyWingCG.py These should be refactored to work with...

Coarse level options for AMG preconditioner

2

## Purpose This PR adds separate ASM overlap, ILU fill level, and inner (ILU) iteration options for the coarse levels when using the AMG preconditioner. The motivation behind this is...