adflow icon indicating copy to clipboard operation
adflow copied to clipboard

SA-R implementation is incorrect

Open sseraj opened this issue 4 years ago • 0 comments

Description

There are two problems with the SA-R implementation here (the same code also appears in the blockette code) when compared to the TMR website:

  1. The min function is missing the minus omega in the second argument. As a result, the min always evaluates to zero and SA-R solutions are identical to SA.
  2. The if statement is checked for both strain and vorticity production, but SA-R is only valid for vorticity production.

sseraj avatar Aug 05 '21 03:08 sseraj