Sabet Seraj

Results 48 comments of Sabet Seraj

Now that #130 is merged, maybe we can fully resolve this bug. What's left to do here @anilyil? I can help with this. Also mentioning #12 for easier reference.

Thanks for the added info. That sounds like a good plan. I'll prioritize the overset/collar mesh tutorials and then come back to this afterwards.

The beta derivative is wrong because of a bug in ADflow. The value needs to be converted from 1/radians to 1/degrees as done for alpha: https://github.com/mdolab/adflow/blob/196caaab17108bf1f85b07fe300c1cc65aaefc2a/adflow/pyADflow.py#L3599-L3600 Did you use a...

Thanks for the detailed report. I am able to reproduce the error. It looks like a bug, but I don't have a good idea on how to fix it right...

Here is a MWE replicating the issue with just analysis on the MACH-Aero tutorial airfoil mesh. This MWE only works on certain numbers of cores (for example 4, 8, 10)....

Unfortunately, I do not have a MWE. I did some more testing and found that the change in behavior is because `ieee_arithmetic` does not work with the `-ffast-math` flag, which...

I ran the tests with `testflo -v` on 16 cores and got these times: With `-ffast-math`: 16:56.60 Without `-ffast-math`: 17:59.36 We don't get too much speedup with `-ffast-math`, so I...

I agree the cluster builds should include optimizations. Do we still use gfortran on Great Lakes? If so, maybe compiling `myisnan` without the flag is better than removing it entirely.

Regardless of what we choose as the default, being able to use `-ffast-math` and also catch NaNs as we currently do is pretty useful. Can we still do this by...

> @sseraj can you use your complex case to test? Yes, I will test this.