Sven Reichel
Sven Reichel
Looks good :+1: Some anoying stuff ... - please add copyright headers to new files - add return types (and type hints) to new methods - run `n98-magerun.phar dev:ide:phpstorm:meta` to...
Thanks for updating :+1: Please add ... - strict_type declaration to all new files - make sure all new methods have parameter + return types (please do not use "mixed")...
@addison74 PR welcome.
Not 100% sure about it ... .. please try it with https://github.com/aschroder/Magento-SMTP-Pro-Email-Extension installed. (and adjust ports)
Tried and failed ... - install your module - added oauth consumer - went to "shooter/rest" - got redirected to customer login - logged in - "shooter/rest/index" shows 404
Uih. Sounds good. Thanks.
>and adds some legitimate errors +570 ... that makes me happy :roll_eyes: Great [PR](https://github.com/macopedia/phpstan-magento1/pull/6)! Thanks.
Still have issues with my ISP. Hope they solve it within next days.
Prior to php7.4 it was far slower. I'd not follow it anymore. Have a read ... - https://dev.to/aleksikauppila/using-isset-and-empty-hurts-your-code-aaa Same for `empty()` - https://dev.to/klnjmm/never-use-empty-function-in-php-4pb0 - https://localheinz.com/articles/2023/05/10/avoiding-empty-in-php/
May I ask where this error comes from? Seems to be 3rd-party code. (?)