magento-lts icon indicating copy to clipboard operation
magento-lts copied to clipboard

Published 20 hours ago • verified publisher icon OpenMage

PHPStan fixes

Open sreichel opened this issue 11 months ago • 6 comments

Description (*)

  • added excluded files to phpstan
  • removed classes w/ missing interface methods (fatal error)
  • some minor fixes

sreichel avatar Dec 07 '24 16:12 sreichel

FYI, I have some updates to the M1 PHPStan plugin that removes some false positive errors and adds some legitimate errors. Will make a PR today or tomorrow.

justinbeaty avatar Dec 07 '24 17:12 justinbeaty

Uih. Sounds good. Thanks.

sreichel avatar Dec 07 '24 17:12 sreichel

and adds some legitimate errors

+570 ... that makes me happy :roll_eyes:

Great PR! Thanks.

sreichel avatar Dec 09 '24 08:12 sreichel

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jan 18 '25 02:01 sonarqubecloud[bot]

It seems we cannot merge it because the branch has conflicts.

addison74 avatar May 22 '25 05:05 addison74

Still have issues with my ISP. Hope they solve it within next days.

sreichel avatar Jun 02 '25 23:06 sreichel