Sven Reichel
Sven Reichel
Can you post a stacktrace and maybe share it? However. Adding checks for existing array-key does not harm.
> OpenMage core should be able to handle such things in a proper way Imho checks for existing keys should be covered by OM.
> I have a simmilar PR pending, `array_key_exists` and if required `is_null` is prefererred over `isset`... > > [#4121 (comment)](https://github.com/OpenMage/magento-lts/pull/4121#issuecomment-2252386633) I think it is bit different there, b/c there are...
@pquerner hey. Had you some time to review this?
Best X-mas wishes :christmas_tree: :)
If you use DDEV, please use XHGUI for performance tests. If it hurts and this feature is not meant to be used in prodution, we can wrap it into `isDeveloperMode()`...
Can you please add a PR?
There is no more effort. Having it baselined makes it easier to track changes. This is a blindly-hit-approved.
You are right, but I cannot answer it. @Flyingmana @colinmollenhour
> Iam not a maintainer anymore, you have to ask my successor as soon as one was selected. Okay. @colinmollenhour can you please port it to v19 and make a...