Sven Reichel

Results 460 comments of Sven Reichel

Thats true, but we cant change mehtod signatures that are possibly overridden/extended.

What do think about to use `isModuleOutputEnabled` to show template parts?

Moving that logic into blocks is great. :) I think about if its usefull to replace `isModuleEnabled` checks with `isModuleOutputEnabled` - to can disable Giftmessage functionallity from backend.

Can you try to create an order with a downloadable product? >Uncaught Error: Class 'Mage_Giftmessage_Helper_Message'

``` Fatal error: Uncaught Error: Class 'Mage_Giftmessage_Helper_Message' not found in /var/www/html/app/Mage.php:616 Stack trace: #0 /var/www/html/app/code/core/Mage/Core/Model/Layout.php(627): Mage::helper('giftmessage/mes...') #1 /var/www/html/app/code/core/Mage/Core/Block/Abstract.php(1105): Mage_Core_Model_Layout->helper('giftmessage/mes...') #2 /var/www/html/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php(132): Mage_Core_Block_Abstract->helper('giftmessage/mes...') #3 /var/www/html/app/design/adminhtml/default/default/template/sales/order/create/items/grid.phtml(427): Mage_Adminhtml_Block_Sales_Order_Create_Items_Grid->isGiftMessagesAvailable() #4 /var/www/html/app/code/core/Mage/Core/Block/Template.php(272): include('/var/www/html/a...') #5 /var/www/html/app/code/core/Mage/Core/Block/Template.php(309):...

Very nice. Thanks for fixing phpstan issues too. First i thought it would be small change ... but no. :) Lets wait for https://github.com/OpenMage/magento-lts/pull/4323. It could replace all `Mage::helper('core')->isModuleOutputEnabled()`

That change to Widget/Grid.php was part of 1.9.4.3 and has been discusses here.