Sven Reichel

Results 224 comments of Sven Reichel

> but I don't know... it's not possible to get the vendor directory name (in case it's a custom one) There is a variable for composer vendor dir ... https://getcomposer.org/doc/03-cli.md#composer-vendor-dir

> what do you think? should I add those lines? "copy" strategy is okay for production, but when developing I prefer symlinks. (can be set separately) I don't like the...

Was something wrong with having these commands in release-builder workflow? If not I'd prefer this.

> I've removed Net_IDNA and switched to a proper polyfill which is allowing us to not have a "if funcion exists" in our code, I kinda prefer this solution, I...

Cant merge b/c conflicts :(

> @sreichel it's just `EVENTS.md` I'll rebase it if you want, but that will remove all the approvals again.. EVENTS.md moved to docs/ ... With saying "i cant merge" i...

> A small issue with this PR (reason why I targeted for v20) is that the cache size will increase depending on how many websites the project has. I want...

> I'd like to have @sreichel opinion on that. I'd like to pass the ball to @colinmollenhour, who has a good knowlegde about Magentos caching. (i'll test too, but this...

> A project I've started multiple times and would love to complete is fixing the broken modularization of M1. One aspect of that is controller locations. W'd like to see...

Yep, there are a lot of them ... Im not sure, about fixing or just remove the whole method ... there are some that could not work and would produce...