Sarah Rambacher
Sarah Rambacher
From my perspective, it would be nice to have separate issues for implementation collected in to this epic https://github.com/patternfly/patternfly/issues/4979
I'm not sure if it was resolved above, but this alignment looks off to me. If it's ok with design, then no problem.
Here are some [best practices for animation] including a plan for handling the media query, accessibility concerns, and performance considerations. (https://docs.google.com/document/d/1U_wEEKLGznFe1HR6zEJbTrx3-j2bA0jj-I7GWihifpU/edit?usp=sharing)
Here's a way it can be done...credit to @mcoker! ``` // default tokens file tokens-default.scss @mixin pf-v6-tokens { --pf-t-thing: foo; --pf-t-thing2: bar; } ``` ``` // dark tokens file tokens-dark.scss...
Also, information about what to replace it with should be somewhere. For example, chip is deprecated and the replacement should be to use a label. Right now I don't think...
Core is still using a dropdown there; https://github.com/patternfly/patternfly/issues/6207 should change that over to a menu-toggle.
I like the cards. I'm a little confused by the about.md and about-PatternFly.md both? They seem to be the same or very similar? Also I do feel like some things...
Nice options for this component. On the switches with check boxes, the checkbox doesn't seem to alternate as the toggle does. Is this intended? Also, just my 2 cents, but...
I see the 1px blue line in Chrome only, and I am on a Mac. (Chrome Version 60.0.3112.113 (Official Build) (64-bit)) Firefox and Safari both look fine to me. ...