patternfly-react
patternfly-react copied to clipboard
Consume core updates: Breadcrumb ( Follow up to issue)
Follow up to core issue https://github.com/patternfly/patternfly/issues/5731
Also depend on core issue https://github.com/patternfly/patternfly/issues/6162 for menu styling
The only thing I noticed was the hover state on this dropdown that doesn't appear in Core. Is that waiting for a menu toggle update? @srambach @mcoker
Core is still using a dropdown there; https://github.com/patternfly/patternfly/issues/6207 should change that over to a menu-toggle.
In chatting with @lboehling about it yesterday, she said that ideally there would be no background color applied to that toggle. We have a button variation that does that, but not a menu toggle variation. For now I was thinking we can just push a CSS update that removes the background for that toggle so no update would need to be made in react. Maybe later we can see if there is a good case for adding that variation as a menu toggle?
Breadcrumb lgtm otherwise!