patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Consume core updates: Breadcrumb ( Follow up to issue)

Open tlabaj opened this issue 1 year ago • 4 comments

Follow up to core issue https://github.com/patternfly/patternfly/issues/5731

Also depend on core issue https://github.com/patternfly/patternfly/issues/6162 for menu styling

tlabaj avatar Jan 02 '24 21:01 tlabaj

Screenshot 2024-02-20 at 2 36 48 PM The only thing I noticed was the hover state on this dropdown that doesn't appear in Core. Is that waiting for a menu toggle update? @srambach @mcoker

andrew-ronaldson avatar Feb 20 '24 18:02 andrew-ronaldson

Core is still using a dropdown there; https://github.com/patternfly/patternfly/issues/6207 should change that over to a menu-toggle.

srambach avatar Feb 20 '24 18:02 srambach

In chatting with @lboehling about it yesterday, she said that ideally there would be no background color applied to that toggle. We have a button variation that does that, but not a menu toggle variation. For now I was thinking we can just push a CSS update that removes the background for that toggle so no update would need to be made in react. Maybe later we can see if there is a good case for adding that variation as a menu toggle?

mcoker avatar Feb 20 '24 21:02 mcoker

Breadcrumb lgtm otherwise!

mcoker avatar Feb 20 '24 21:02 mcoker