Sarah Rambacher

Results 57 comments of Sarah Rambacher

CSS review: **pikaday** - Written in SCSS - Does not use BEM - Fairly flat structure, selectors to 2 levels - Uses old *attribute that was used for IE6 -...

**bootstrap-datepicker** - written in Less - does not use BEM - Nested selectors such as `.datepicker table tr td.range.today` are the norm - No variables for configuration; all magic numbers...

Follow up to look at using a transform to generate token variables with rem values at https://github.com/patternfly/design-tokens/issues/47

I think this came out of a recent conversation specifically about React tokens (which are the React version of our CSS variables). This includes more than just token variables. This...

@kmcfaul I think @adamviktora 's suggestions are the core of this issue so I think it's worth doing before merging this rather than making another issue.

These are now base-level z-index tokens coming in from Figma available to use. Components that are currently using the old global variable zindexes should now use the tokens. In the...

After discussion with design, expanding the focus ring for buttons out a bit seems the best solution.

Cool idea, @ryanaltvater! Thanks for contributing! The bookmarklet works well. I forked your CodePen and made some changes to the CSS to flatten it out and make the BEM naming...

Oops, I probably never hit Save! Try again now @ryanaltvater :-)