Benedikt Franke
Benedikt Franke
> Hello should I add the directive description in the docs md file? Eventually, yeah. Let's make sure it is properly described first.
There is a typo in the title, and tests are failing.
> > There is a typo in the title, and tests are failing. > > Can you give me more details about the test error? You can look at the...
> Ok..., I pushed another commit...hope will be succeed You don't have to hope, you can run the tests locally. See https://github.com/nuwave/lighthouse/blob/master/CONTRIBUTING.md. Please let me know when every comment has...
> Finally, I tested locally and both tests were successful. There are still plenty of unresolved discussions. Please address them all.
> NEW COMMIT PUSHED I am a bit irritated by your use of ALL CAPS. Anyways, thanks for making the requested changes. I think I failed to communicate how I...
> @spawnia what do you think about [#1426 (comment)](https://github.com/webonyx/graphql-php/pull/1426#issuecomment-1678562672) Sounds interesting, perhaps you can illustrate that approach in a second pull request and allow us to compare?
I don't mind adding a link to your example in the docs. A couple of notes: - How do we know it is working? There are no tests? - What...
1. Yeah, some integration tests to show that the resolvers are working as intended would be great. There can still be mistakes, such as typos in field names, mismatches in...
Using a TypeRegistry makes sense, especially for an example like yours that should be at least somewhat complete and production ready-ish.